Skip to content

Fix Essentials' logger breaking on 1.8.8-1.12.2 #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JRoy merged 1 commit into from
Jul 2, 2022
Merged

Fix Essentials' logger breaking on 1.8.8-1.12.2 #4975

JRoy merged 1 commit into from
Jul 2, 2022

Conversation

@JRoy
Copy link
Member

@JRoy JRoy commented Jul 1, 2022

Fixes an issue with our new logger system that prevented loading on 1.8.8

@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module module: discord Issues or PRs for the EssentialsDiscord module module: chat Issues or PRs for the EssentialsChat module module: spawn Issues or PRs for the EssentialsSpawn module module: xmpp Issues or PRs for the EssentialsXMPP module module: geo Issues or PRs for the EssentialsGeo module module: protect Issues or PRs for the EssentialsProtect module labels Jul 1, 2022
@JRoy JRoy added this to the 2.19.5 milestone Jul 1, 2022
@JRoy JRoy changed the title Fix 1.8.8 compatibility Fix Essentials' logger breaking on 1.8.8-1.12.2 Jul 2, 2022
@JRoy JRoy merged commit a60f3c0 into EssentialsX:2.x Jul 2, 2022
@JRoy JRoy deleted the i-hate-legacy branch July 2, 2022 18:50
JRoy added a commit that referenced this pull request Jul 7, 2022
@JRoy
Fix Essentials' logger breaking on 1.8.8-1.12.2 (#4975)
2bb5e76
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
@JRoy
Fix Essentials' logger breaking on 1.8.8-1.12.2 (EssentialsX#4975)
ca1cebd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdcfe mdcfe mdcfe approved these changes

@pop4959 pop4959 pop4959 approved these changes

Assignees

No one assigned

Labels

module: chat Issues or PRs for the EssentialsChat module module: discord Issues or PRs for the EssentialsDiscord module module: geo Issues or PRs for the EssentialsGeo module module: main Issues or PRs for the main Essentials module module: protect Issues or PRs for the EssentialsProtect module module: spawn Issues or PRs for the EssentialsSpawn module module: xmpp Issues or PRs for the EssentialsXMPP module type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Milestone

2.19.5

Development

Successfully merging this pull request may close these issues.

3 participants

@JRoy @mdcfe @pop4959