-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ability to use texture url in /skull #5120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Overall this looks good, but it would be great if you could add an additional command usage message to indicate that texture URL hashes are accepted.
mdcfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay in re-reviewing this! The new usage message looks good.
This PR will need updating and conflicts resolving before it can be merged. If you get a chance to do this, it would be great, but if not we can resolve this before we merge it.
|
All good, sure! I'll get the conflicts resolved as soon as possible. |
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com> Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>

Information
This PR closes #3804.
Details
Proposed feature:
This lets users provide custom skins when using the
/skullcommand by specifying a skin identifier instead of a username. This feature is only available on specific versions of Spigot 1.18.1 and above because it uses the new player profile API. On older versions, only a username can be used.The
/skullcommand now supports the following values in the first argument:The first 7 characters of the skin identifier will be used for the skull's display name and the success message. An error message will be sent if a base64 value isn't a valid skin object.
Environments tested:
OS: Windows 11
Java version: openjdk version "17.0.1" 2021-10-19
CraftBukkit/Spigot/Paper 1.12.2CraftBukkit 1.8.8Demonstration:
I used this head as an example. The screenshot below was taken immediately after running the following commands (and switching my hotbar slot in between):