Allow configuring Discord webhook name #5159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR partially closes #5155
Details
Proposed feature:
Add a template for the webhook name instead of hardcoding the three options (bot name, username, display name) as booleans.
This removes the options
show-nameandshow-displayname. They are still read as a fallback for if this new format is undefined.The default behaviour currently is to use the bots name, so the default template is
{botname}.botnameis a placeholder for the bots name in the server.Environments tested:
OS: Fedora 36
Java version:
17.0.5Don't see how this could differ on other server versions.
Demonstration: