Skip to content

Fix config BigDecimal parsing returning null on error #5373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JRoy merged 2 commits into from
May 31, 2023
Merged

Fix config BigDecimal parsing returning null on error #5373

JRoy merged 2 commits into from
May 31, 2023

Conversation

@JRoy
Copy link
Member

@JRoy JRoy commented May 31, 2023 •
edited
Loading

Also add some more exception logging for parse issues.

@JRoy
Fix config BigDecimal parsing returning null on error
e436573 
Also add some more exception logging for parse issues
@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels May 31, 2023
@JRoy JRoy added this to the 2.20.1 milestone May 31, 2023
@JRoy JRoy merged commit cdd277d into EssentialsX:2.x May 31, 2023
@JRoy JRoy deleted the fix/my-past branch May 31, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pop4959 pop4959 pop4959 approved these changes

+4 more reviewers

@mbax mbax mbax approved these changes

@LaxWasHere LaxWasHere LaxWasHere approved these changes

@Chew Chew Chew approved these changes

@Evidentsinger14 Evidentsinger14 Evidentsinger14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Milestone

2.20.1

Development

Successfully merging this pull request may close these issues.

6 participants

@JRoy @mbax @LaxWasHere @Chew @pop4959 @Evidentsinger14