Skip to content

Conversation

@Evidentsinger14
Copy link
Member

Information

This PR does not close any issues

Details

Proposed fix:
fixes colors being parsed when using minimessage tags in the currency locale key.

Environments tested:

OS:
Windows 10

Java version:
Java 21

  • Most recent Paper version (1.21.1-51-master@789a267)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:
before fix:
image

after fix:
image

@mdcfe mdcfe requested a review from JRoy September 1, 2024 18:52
@mdcfe mdcfe added this to the 2.21.1 milestone Sep 1, 2024
@mdcfe mdcfe added the module: main Issues or PRs for the main Essentials module label Sep 15, 2024
@JRoy JRoy changed the title fix MM parsing in NumberUtil Fix mini message parsing in NumberUtil#displayCurrency Nov 25, 2024
@JRoy JRoy enabled auto-merge (squash) November 25, 2024 02:10
@JRoy JRoy added the type: bugfix PRs that fix bugs in EssentialsX. label Nov 25, 2024
@JRoy JRoy merged commit bea43e8 into EssentialsX:2.x Nov 25, 2024
1 check passed
@Evidentsinger14 Evidentsinger14 deleted the fix/balance-parsing branch November 27, 2024 01:02
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Dec 10, 2024
EssentialsX@1778bf5 Respect per player locale for command descriptions (EssentialsX#5972)
EssentialsX@2418a6f Improvements to Random Teleport (EssentialsX#4271)
EssentialsX@38e42f9 Add argument to /skull to give skull to other player (EssentialsX#5822)
EssentialsX@1af1565 Discord: Add start time placeholder for start message (EssentialsX#5686)
EssentialsX@bea43e8 Fix mini message parsing in NumberUtil#displayCurrency (EssentialsX#5921)
EssentialsX@3203e97 Parse /pay modifiers more strictly (EssentialsX#5638)
EssentialsX@f02eeec Add method to get all linked players in DiscordLinkService (EssentialsX#5896)
EssentialsX@9590d4c Add translation key for /alts output (EssentialsX#5595)
EssentialsX@3f0a412 Add locale based comma support for /pay (EssentialsX#5962)
EssentialsX@57c9edc Add optional requirements for balance top listing (EssentialsX#5394)
EssentialsX@c7cc1b4 Fix respawn-at-anchor setting. (EssentialsX#5825)
EssentialsX@2a41ea0 Add config options for specific chat type formats
EssentialsX@b560bbd Fix actions permissions on PRs for junit reports
EssentialsX@d31ff55 Remove extraneous code in command preprocess event handling
EssentialsX@bc8aa76 Revert removal of InvalidWorldException (EssentialsX#5984)
EssentialsX@d58db0d Update to 1.21.4
EssentialsX@c37064f Add 1.21.4 Mobs
EssentialsX@baa8258 Add 1.21.4 Tree Types
EssentialsX@424816e Add 1.21.4 Items
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
)

Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
@mdcfe mdcfe modified the milestones: 2.21.1, 2.21.0 Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants