Fix startup issue with potion providers #6055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LegacyPotionMetaProvider was initializing a map with enums that don't exist on modern versions. Since this was a static variable, this map got initialized when the test method was called, leading to a NoSuchFieldError. Also improved resilience of these provider-type issues again by catching a Throwable rather than an Exception in the ProviderFactory.
JRoy
added
type: bugfix
pop4959
approved these changes
Feb 19, 2025
Euphillya
added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Mar 1, 2025
EssentialsX@196a2a1 Fix startup issue with potion providers (EssentialsX#6055) EssentialsX@8313d52 Add config for use of Paper chat events (EssentialsX#6050) EssentialsX@3025ba5 Fix NPE when chat messages are canceled EssentialsX@5a839c4 Fix modifying messages with Paper chat events EssentialsX@e3e247d Add discord module support for Paper's chat events (EssentialsX#5908) EssentialsX@263dab5 Fix spawn command sending message before teleportation (EssentialsX#6025) EssentialsX@f5efa26 Fix per-world flight permissions EssentialsX@1ff24cb Use an identity map for Paper chat listener (EssentialsX#6067) EssentialsX@bad79b7 Fix /book command on 1.20+ (EssentialsX#6064) EssentialsX@5458241 Fix expired mails showing as unread on join (EssentialsX#6063) EssentialsX@fe27182 New Crowdin updates (EssentialsX#6037) EssentialsX@ba5257c Fix translation error in EssentialsSign#getItemStack EssentialsX@e49021f Fix item overflow issue with kits & trade signs EssentialsX@b5748eb Update various dependencies (EssentialsX#6078)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LegacyPotionMetaProvider was initializing a map with enums that don't exist on modern versions. Since this was a static variable, this map got initialized when the test method was called, leading to a NoSuchFieldError.
Also improved resilience of these provider-type issues again by catching a Throwable rather than an Exception in the ProviderFactory.
Fixes #6054