potential bug in sympound.py?

[Horace89]

Hi. Just noticed that on L69:
if count >= countThreshold:
So if I understand correctly, maybe you should replace the line with
if count >= self.countThreshold:

[eroux]

It looks so, thanks a lot! Would you have time to open a PR?

[Horace89]

Sadly no. I'm away from my coding PC for a few days. BTW I have other questions/remarks about the code. Are you interested if I write them down?

[eroux]

Sure, please go ahead! I'll fix the little bug

[eroux]

fixed in aa647d5

[Horace89]

Here you are.
Some variables look unused:

self.enable_compound_check
self.initialCapacity = initialCapacity # so the constructor parameter initialCapacity is of no use for now.
self.compactLevel = min(compactLevel, 16) # so the constructor parameter compactLevel is of no use for now.
self.edit_distance_max

L68, L75:
do you mean:

count = count_previous+count if (sys.maxsize - count_previous > count) else sys.maxsize

L87-90:
I think it would be clearer to use a Defaultdict for self.deletes.

On L56 :

from collections import defaultdict
self.deletes = defaultdict(list)

Then you replace L87-90 by:

self.deletes[deleteHash].append(key)

L286-L288:
range(0, len(xxx)) can be rewritten with range(len(xxx))

You may even replace

suggestions_previous_term = []
for k in range(0, len(suggestions)):
   suggestions_previous_term.append(copy(suggestions[k]))

with a list comprehension:
suggestions_previous_term = [copy(suggestions[k]) for k in range(len(suggestions))]
or better:
suggestions_previous_term = [copy(suggestion) for suggestion in suggestions]
same thing for suggestions on L172

That's it for now. As I said, I don't have my coding PC for now so I cannot test other ideas.

[eroux]

I've incorporated most of your suggestions, thanks a lot!