Fix potential Serilog load error, enable debug logging into msbuild#40
Merged
Lordfirespeed merged 6 commits intoEvaisaDev:mainfrom Jun 22, 2024
Merged
Conversation
Contributor
Author
|
Would any of you mind having a look at this PR @EvaisaDev or @Lordfirespeed? |
Lordfirespeed
requested changes
Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As is,
Default.LoadFromAssemblyNamemay fail to load the Serilog dependency when using the MSBuild SDK, leading to exceptions like:This PR adds code to attempt to manually resolve the assembly from the
PatcherCommonAssemblyDirbefore deferring to theDefaultContext.Additionally it changes the LoggingConfiguarion for the MSBuild Task to also emit Debug messages. These are only shown when MSBuild'ing with verbosity detailed or higher anyway, but filtering them out in the Task leaves them completely inaccessible.