fix: replace 4 bare excepts with except Exception#91
Open
haosenwang1018 wants to merge 1 commit intoEverMind-AI:mainfrom
Open
fix: replace 4 bare excepts with except Exception#91haosenwang1018 wants to merge 1 commit intoEverMind-AI:mainfrom
haosenwang1018 wants to merge 1 commit intoEverMind-AI:mainfrom
Conversation
Bare `except:` catches BaseException including KeyboardInterrupt and SystemExit. Replaced 4 instances with `except Exception:`.
haosenwang1018
force-pushed
the
fix/bare-excepts
branch
from
3235c94 to
d93bfa7
Compare
Jah-yee
pushed a commit
to Jah-yee/EverMemOS
that referenced
this pull request
Mar 10, 2026
… replace bare except - Rename stage3_memory_retrivel.py to stage3_memory_retrieval.py (typo fix) - Replace == None with is None in mem_memorize.py and test files - Replace != True with is not True in repository files - Replace bare except with except Exception in production and test files Fixes EverMind-AI#115 EverMind-AI#113 EverMind-AI#107 EverMind-AI#91 EverMind-AI#98
Jah-yee
pushed a commit
to Jah-yee/EverMemOS
that referenced
this pull request
Mar 12, 2026
- Rename stage3_memory_retrivel.py to stage3_memory_retrieval.py (typo fix) - Replace == None with is None (Python anti-pattern) - Replace != True with is not True (Python anti-pattern) - Replace bare except with except Exception - Remove duplicate 'rrf' entry in docstring - Remove unused MongoDB init script volume mount from docker-compose.yaml - Add missing env template setup step in STARTER_KIT.md quick start Fixes: EverMind-AI#115, EverMind-AI#113, EverMind-AI#107, EverMind-AI#97, EverMind-AI#91, EverMind-AI#90, EverMind-AI#86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
except:withexcept Exception:across 4 files.Why: Bare
except:catchesBaseExceptionincludingKeyboardInterruptandSystemExit.except Exception:preserves fallback behavior while allowing system exceptions to propagate.Files:
mem_db_operations.py,episodic_memory_milvus_repository.py,test_conv_memcell_extractor.py,test_group_user_profile_memory_raw_repository.py