feat: update useAnalyticsPageView parameter #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 이제 callback 함수를 입력 받을 수 있습니다. - regular function으로 변경하고 overloading을 추가했습니다.
greatSumini
changed the title
greatSumini
force-pushed
the
enhance/171/enhance-use-analytics-page-view
branch
from
ff4845d to
a3c8a18
Compare
p-iknow
reviewed
Aug 31, 2021
p-iknow
approved these changes
Aug 31, 2021
p-iknow
approved these changes
Aug 31, 2021
sensecodevalue
approved these changes
Sep 1, 2021
Contributor
sensecodevalue
left a comment
sensecodevalue
left a comment
There was a problem hiding this comment.
고생하셨습니다! 코드랑 리뷰보고 많이 배워갑니다!
비동기 대기 인라인 코드를 함수로 만들어 중복을 제거했습니다.
console.info를 mocking하여 불필요한 log 발생을 없앴습니다.
…ics-provider into enhance/171/enhance-use-analytics-page-view
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
============================================
- Coverage 100.00% 88.88% -11.12%
============================================
Files 4 7 +3
Lines 32 54 +22
Branches 2 3 +1
============================================
+ Hits 32 48 +16
- Misses 0 6 +6
Continue to review full report at Codecov.
|
Member
|
뒷북: 넘 좋아요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Help Wanted 👀
Related Issues
resolve #171
fix #
Checklist ✋
{PR type}: {PR title}로 맞췄습니다. (type 예시: feat | fix | BREAKING CHANGE | chore | ci | docs | style | refactor | perf | test) (참고: conventional commits)npm run build,npm run test)