feat: add ce:review-beta with structured persona pipeline#348
Conversation
tmchow
changed the title
ce:review-beta with structured persona pipeline
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8ebed3cba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01ca2b4dee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d42aaba2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cd6d67fff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e56c3fba36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d007aa6784
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc18dc1646
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tmchow
force-pushed
the
feat/compare-review-skills
branch
from
dc18dc1 to
00d7deb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f882638cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a721eecf9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3febc62a74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c79ecb07f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db5db938c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ona agents Add a structured, multi-agent code review skill with: - 8 specialized reviewer persona agents (correctness, security, testing, maintainability, performance, reliability, api-contract, data-migrations) - Tiered review modes: interactive, autonomous, and report-only - Structured findings schema with severity, confidence, autofix classification - Read-only reviewer contract with non-mutating git/gh inspection - Promotion contract documenting path from beta to stable ce:review
tmchow
force-pushed
the
feat/compare-review-skills
branch
from
76bf361 to
70e8729
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70e87292c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… in review-beta The autonomous mode handoff creates todos/ items but didn't specify the format. Now explicitly loads the file-todos skill and maps finding severity to todo priority.
… FETCH_HEAD in review-beta - Branch-mode and standalone-mode base resolution now mirrors PR-mode logic, resolving from the PR's actual base repository instead of assuming origin - FETCH_HEAD is only read after a successful fetch to avoid stale refs from unrelated prior fetches
Adds codex-reviewer agent for cross-model code review validation. Rebased onto main after EveryInc#348 merge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Summary
ce:review-beta, a new beta review skill that replaces ce:review's free-form agent dispatch with a structured 6-stage pipeline adapted from the iterative-engineering plugin's code-review skillWhy this is different from ce:review
The existing
ce:reviewdispatches autonomous agents (security-sentinel, performance-oracle, etc.) that return unstructured prose reports. The orchestrator collects these reports and synthesizes them for the user.In practice, this produces reviews where real bugs get buried in noise. An agent told to "be paranoid and leave no stone unturned" will generate 15 findings, but only 3 are real problems -- the rest are vague suggestions like "consider adding rate limiting" or defensive coding advice for values that can't actually be null. With 5+ agents running, the same unbounded query gets flagged by both the security and performance agents with different framing, so the report looks twice as long as it should. And every finding looks equally important because there's no way to distinguish "this will crash in production" from "this might theoretically be an issue at extreme scale." The user ends up manually triaging the review output itself, which defeats the purpose of automated review.
ce:review-betafixes this with pipeline-level quality control:Review modes
The skill supports three execution modes, chosen by passing a mode token in the arguments:
mode:autonomoussafe_autofixes, re-reviews in bounded rounds, writes a run artifact, and emits residual work asfile-todosfor downstream resolution.mode:report-onlyThe mode design supports pipeline composition: an orchestrator can run
mode:report-onlyin parallel with other tools on the same checkout, then follow up withmode:autonomousin a dedicated worktree for fixes.The persona agents
8 new agents in
agents/review/, each with:tools: Read, Grep, Glob, Bashfrontmatter for read-only enforcementfindings-schema.jsonThe
data-migrations-reviewerwas enhanced beyond the iterative-engineering source with items from CE's existingdata-migration-expert(swapped ID/enum mapping detection, dual-write validation, orphaned reference search).CE-specific adaptations
On top of the iterative-engineering base:
agent-native-reviewerandlearnings-researcheras always-on CE agentsschema-drift-detectoranddeployment-verification-agentas conditional (migration PRs)docs/brainstorms/,docs/plans/,docs/solutions/are discardedTest plan
/ce:review-betaon a PR with code changes -- verify structured output with confidence scores/ce:review-betaon a PR with migration files -- verify conditional agents (data-migrations, schema-drift-detector) are selected/ce:review-betawith no argument on a feature branch -- verify standalone mode works/ce:review-beta <branch-name>for a branch without a PR -- verify branch mode doesn't fail/ce:review-beta mode:autonomous-- verify no user interaction, safe_auto fixes applied, residual todos created/ce:review-beta mode:report-only-- verify strictly read-only, no edits or mutations/ce:review-beta mode:report-only <PR-number>-- verify it refuses to switch the shared checkoutbun run release:validatepasses