feat: integrate orphaned stack-specific reviewers into ce:review#375
Merged
feat: integrate orphaned stack-specific reviewers into ce:review#375
Conversation
…ctured pipeline Adapt 5 previously orphaned opinionated review agents (dhh-rails, kieran-rails, kieran-python, kieran-typescript, julik-frontend-races) to work within the ce:review structured findings pipeline. These agents were lost when review-beta was promoted to stable and the skill was declared language-agnostic. Each agent now follows the structured contract (JSON output, confidence calibration, suppress-below-0.60, "What you don't flag" guardrails) while preserving its opinionated lens. The skill adds a new "stack-specific conditional" tier that is additive with cross-cutting conditionals, with explicit guidance to not spawn mechanically from file extensions alone. Restores kieran-rails Turbo stream template convention and julik Symbol-based state machine recommendation that were lost in the condensation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new
ce:reviewskill that was promoted from beta, accidentally lost the opinionated tech stack specific agents. This PR resolves that and brings them back into the fold. Say hello again to the Kieram. DHH and Julik agents 👋dhh-rails,kieran-rails,kieran-python,kieran-typescript,julik-frontend-races) into thece:review` structured findings pipelinece:review-betawas promoted to stable and the skill was declared language-agnosticKey design decisions
Test plan
bun test tests/review-skill-contract.test.tspasses (8 tests, 95 assertions)/ce:reviewon a Rails branch and verify stack-specific agents are selected and produce structured JSON/ce:reviewon a config-only change and verify stack-specific agents are NOT selected