Skip to content

feat: integrate orphaned stack-specific reviewers into ce:review#375

Merged
tmchow merged 1 commit intomainfrom
feat/review-structured-conditional-agents
Mar 25, 2026
Merged

feat: integrate orphaned stack-specific reviewers into ce:review#375
tmchow merged 1 commit intomainfrom
feat/review-structured-conditional-agents

Conversation

@tmchow
Copy link
Copy Markdown
Collaborator

@tmchow tmchow commented Mar 25, 2026

Summary

The new ce:review skill that was promoted from beta, accidentally lost the opinionated tech stack specific agents. This PR resolves that and brings them back into the fold. Say hello again to the Kieram. DHH and Julik agents 👋

  • Adapts 5 orphaned opinionated review agents (dhh-rails, kieran-rails, kieran-python, kieran-typescript, julik-frontend-races) into the ce:review` structured findings pipeline
  • These agents were lost when ce:review-beta was promoted to stable and the skill was declared language-agnostic
  • Adds a new "stack-specific conditional" tier that is additive with cross-cutting conditionals
  • Each agent now follows the structured contract (JSON output, confidence calibration, 0.60 suppress threshold, "What you don't flag" guardrails) while preserving its opinionated lens

Key design decisions

  • Stack-specific agents are not spawned mechanically from file extensions — the trigger is meaningful changed behavior in that stack
  • Restored kieran-rails Turbo stream template convention and julik Symbol-based state machine recommendation lost during condensation
  • Contract tests verify all 5 agents match the pipeline schema (tools, confidence calibration, JSON output, reviewer name)

Test plan

  • bun test tests/review-skill-contract.test.ts passes (8 tests, 95 assertions)
  • Manual: run /ce:review on a Rails branch and verify stack-specific agents are selected and produce structured JSON
  • Manual: run /ce:review on a config-only change and verify stack-specific agents are NOT selected

…ctured pipeline

Adapt 5 previously orphaned opinionated review agents (dhh-rails, kieran-rails,
kieran-python, kieran-typescript, julik-frontend-races) to work within the
ce:review structured findings pipeline. These agents were lost when review-beta
was promoted to stable and the skill was declared language-agnostic.

Each agent now follows the structured contract (JSON output, confidence
calibration, suppress-below-0.60, "What you don't flag" guardrails) while
preserving its opinionated lens. The skill adds a new "stack-specific
conditional" tier that is additive with cross-cutting conditionals, with
explicit guidance to not spawn mechanically from file extensions alone.

Restores kieran-rails Turbo stream template convention and julik Symbol-based
state machine recommendation that were lost in the condensation.
@tmchow tmchow merged commit ce9016f into main Mar 25, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 25, 2026
@github-actions github-actions Bot mentioned this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant