fix(ce-plan, ce-brainstorm): reliable interactive handoff menus#575
Merged
fix(ce-plan, ce-brainstorm): reliable interactive handoff menus#575
Conversation
…andoff Trim handoff menus to ≤4 options so AskUserQuestion can present them as native choices instead of falling back to a chat list. Inline the question-tool directive at each handoff point instead of pointing back to the main skill, and sharpen option labels and descriptions so users can pick with confidence. - ce:plan handoff: consolidate to Start /ce:work, Create Issue, View & share in Proof, Done for now. Restore Create Issue with tracker auto-detect and a one-time persist to AGENTS.md. Drop "Open plan in editor" and "Start /ce:work in another session" (not reliably achievable from a skill). Surface additional document review contextually when residual P0/P1 findings remain. - ce:brainstorm handoff: rename "Ask more questions" to "Continue the brainstorm" with a consistent, non-first-person description. Surface additional document review contextually. Gate Proof so total options stay at 4 or fewer in every scenario. - Rename "Share to Proof" to "View & share in Proof" across both skills (including universal-brainstorming) so the view/collaborate value is visible in the label. - Update pipeline-review-contract tests to assert the contextual document-review surface rather than the removed menu fixture.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57543d03a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- ce-brainstorm handoff: align per-option annotations with the existing Resolve Before Planning gate so paused/blocked brainstorms don't present planning as selectable - ce-plan issue creation: persist the lowercase tracker key (github/linear) instead of the display label so the detector in step 1 matches on future runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ce:planand/ce:brainstormboth show the user a menu at the end of their workflow. That final question was falling back to a numbered chat list instead of using the platform's interactive question tool, even though earlier questions in the same session worked fine. Cause: late-loaded reference files pointed back at the main skill with "(see Interaction Method)" instead of restating the rule inline, menus had grown to 6 options (overAskUserQuestion's native-choice budget), and several labels didn't tell the user what picking them would actually do.After this change, handoff menus fit inside a 4-option budget at every branch, the question-tool directive is inlined at each handoff point, and every label describes the action it takes.
Fixes #571
What changed
/ce:planhandoff — always 4 options:Start /ce:work(recommended)Create Issue— restored with tracker auto-detected fromAGENTS.mdand a one-time prompt to persistproject_tracker:on first useView & share in Proof— renamed fromShare to Proof; description now covers read, comment, collaborate, and shareDone for nowDropped:
Open plan in editor(covered by Proof),Start /ce:work in another session(not reliably achievable from a skill), andRun additional document reviewas a menu fixture. The last is surfaced contextually now — when the priordocument-reviewpass left residual P0/P1 findings, the handoff mentions them in prose adjacent to the menu and offers another pass./ce:brainstormhandoff — up to 4 options:Proceed to planning (Recommended)Proceed directly to work— only when the direct-to-work gate is satisfiedContinue the brainstorm— renamed fromAsk more questions; description is self-contained ("Answer more clarifying questions to tighten scope, edge cases, and preferences")View & share in Proof— gated so the total stays at 4 (doc exists AND direct-to-work gate closed)Done for nowSame contextual surfacing for additional document review. Labels avoid first-person voice so "who is the 'I' here?" never comes up.
Shared:
AskUserQuestionin Claude Code,request_user_inputin Codex,ask_userin Gemini) instead of indirecting to the main skill.Share to Proof→View & share in Proofwherever it appears (including universal brainstorming) so the view/collaborate value shows up in the label, not just the description.Why ≤4 options
AskUserQuestionrenders up to 4 options as native single-select choices. Exceed that, and the tool declines silently and the skill emits a chat list instead — which is exactly what users reported for the final handoff question. Trimming to ≤4 at every branch restores consistent rendering alongside the other decision points in the same session.Test plan
pipeline-review-contractasserts the new contextual-surface contract for additional document review and the new(recommended)label position — updated in this PR./ce:planor/ce:brainstormend-to-end in Claude Code and confirm the final handoff renders as a native selector, not chat text.