fix(git-commit-push-pr): apply PR description after delegate hand-off#594
Merged
fix(git-commit-push-pr): apply PR description after delegate hand-off#594
Conversation
… hand-off Split the generate/apply sequence in Step 7 (existing PR) and DU-3 (description update) into numbered sub-steps so "apply" can't be skipped as a dependent clause after ce-pr-description returns. Align placeholder labels with ce-pr-description's return block (<TITLE>, <BODY_FILE>) and note the shell-escape hazard when a title contains ", \`, \$, or \\.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where
git-commit-push-prwould generate a new PR description viace-pr-descriptionand then stop without applying it. Root cause: the apply step was phrased as a subordinate clause ("run step 6, then apply...") after the delegate's=== TITLE ===/=== BODY_FILE ===return block, and that return block reads as a natural stopping cue.Promote "apply" to a first-class numbered sub-step with an explicit hand-off-boundary preamble at all three apply sites: Step 7 existing-PR, Step 7 new-PR, and DU-3 description-update. Also align placeholder tokens with
ce-pr-description's actual return labels (<TITLE>/<BODY_FILE>, previously<returned title>/<returned body_file>) and note the shell-escape hazard for titles containing",`,$, or\.