feat(ce-resolve-pr-feedback): drop bot noise, centralize test runs#610
Merged
feat(ce-resolve-pr-feedback): drop bot noise, centralize test runs#610
Conversation
…pers, split test responsibility - Filter CodeRabbit, Codex, Gemini, Copilot, and Codecov top-level comments and review bodies in get-pr-comments. These bots put actionable feedback in inline review threads; their wrapper bodies are reliable noise and the agent repeatedly narrated ignoring them. Also trim unused url/createdAt fields from the GraphQL payload. - Add silent-drop rule so the agent stops announcing non-actionable items. - Split test responsibility: resolvers run only targeted tests for what they changed (specific file, pattern, or the test they wrote), never the full project suite. Orchestrator runs the project's validation once against the combined diff before commit. Covers pre-existing failures (note in footer), failures in touched files (one inline retry, then escalate), and the zero-changes skip path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two wins for
ce-resolve-pr-feedback, both cutting per-thread work that should happen once per invocation:Bot wrapper filter
scripts/get-pr-commentsdrops known review-bot and CI-bot authors frompr_commentsandreview_bodiesin the jq pipeline, before the skill sees them:coderabbitai,chatgpt-codex-connector,gemini-code-assist,copilot-pull-request-reviewer— AI review bots whose top-level output is wrapper text; their actionable asks are inline and still processed asreview_threads.codecov— CI summary, never actionable on its own.The filter list is narrow by design: exact logins, not patterns, so future bots that post genuinely actionable top-level content are not suppressed preemptively. The GraphQL payload also drops
urlandcreatedAtfields that weren't consumed downstream.The skill gains an explicit silent-drop rule for any wrapper that slips through the script — no announcing, counting, or surfacing dropped items. Removes the "ignoring the Codex bot comment" chatter from the skill's output.
Test split between resolver and orchestrator
Parallel resolvers previously ran the full project test suite in isolation, duplicating work (N × full-suite time, N × test output read by the model) and never validating the merged diff.
reasonand the orchestrator catches issues in the combined run. No verdict downgrade.files_changedand runs the project's validation command once against the combined diff. Three outcomes: green proceeds to commit, red in touched files gets one inline fix attempt before escalatingneeds-human, red in untouched files is treated as pre-existing and noted in the commit footer.Steps 6-9 renumbered to 7-10 to accommodate the new Validate step. Step 10 summary includes a one-line validation outcome (
Validation: bun test passed (893/893)).Test plan
bun testgreen (893/893). Frontmatter and converter tests would catch a malformed skill change or a broken script.bun run release:validatein sync.siddharthvaddem/openscreen#471(CodeRabbit + Codex),GoogleCloudPlatform/cluster-toolkit#5531(Gemini),jaegertracing/jaeger-ui#3740(Copilot + Codecov). Every bot wrapper filtered; human reviewer comments preserved in each case.