fix(ce-plan): inline handoff menu so post-plan options are never skipped#615
Merged
fix(ce-plan): inline handoff menu so post-plan options are never skipped#615
Conversation
The 5.3.8-5.4 section deferred both the trigger (present the menu) and branching (issue creation, Proof flow) to references/plan-handoff.md. Agents reaching the "confidence check passed" exit would stop after writing the plan, never loading the reference, and instead offer to start ce-work in prose. Fixes: - 5.3.2 "no deepening" exit now imperatively loads the reference - 5.3.8-5.4 stub now inlines the menu question + 4 options; branching logic stays in the reference - Terminal line replaced with an explicit completion check - "NEVER CODE" moved to Phase 4 (where implementation temptation is live)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents running
ce-plancould write the plan file, offer to start/ce-workin prose, and stop, skipping the blocking post-generation menu that should gate the handoff. This PR restructures the final phase so the menu cannot be missed.What was happening
SKILL.mddeferred both the trigger action (present the menu) and the branching logic (issue creation, Proof HITL flow) toreferences/plan-handoff.md. The confidence-check "passed" exit in 5.3.2 pointed to Phase 5.3.8 by section number. The 5.3.8 to 5.4 stub in turn said, in passive voice, "read this reference file when reaching this phase." The skill then ended withNEVER CODE! Research, decide, and write the plan., which reads as a terminal completion admonition.On the common path where the confidence check passed and no deepening was needed, the agent never re-entered the skill body at 5.3.8, never loaded the reference, and treated writing the plan as the final act.
Fix
load references/plan-handoff.md now and execute 5.3.8, 5.3.9, 5.4 in sequence. The load is the instruction, not a section signpost.SKILL.md. Branching (issue creation, Proof HITL, post-HITL resync) stays in the reference.NEVER CODEmoves to Phase 4, where implementation temptation is actually live. The final line is no longer a behavior guardrail that reads as a stop signal.The extraction architecture (offload detailed branching to a reference) is preserved. Only the trigger (the 10-line menu itself) moves inline. Pattern: defer branching, never defer the trigger.
Test plan
/ce-planon a low-risk scenario where the confidence check exits early. Confirm the agent loadsplan-handoff.md, runsce-doc-review, and presents the blocking menu before stopping.