Skip to content

feat(ce-commit-push-pr): skip evidence prompt when judgment allows#663

Merged
tmchow merged 1 commit intomainfrom
tmchow/ce-pr-skip-rote
Apr 23, 2026
Merged

feat(ce-commit-push-pr): skip evidence prompt when judgment allows#663
tmchow merged 1 commit intomainfrom
tmchow/ce-pr-skip-rote

Conversation

@tmchow
Copy link
Copy Markdown
Collaborator

@tmchow tmchow commented Apr 23, 2026

Summary

ce-commit-push-pr previously walked the full evidence-decision ladder on every invocation, asking a blocking user question whenever the branch diff showed observable behavior. That prompt fires often on chained ce-commitce-commit-push-pr runs, where the agent just authored the commits and already knows the change's character — so the prompt rarely adds value and interrupts flow.

Two short-circuits now run before the full decision:

  1. User-requested evidence. If the invocation explicitly asked for a demo or screenshot, proceed directly to capture, with graceful fallback when capture is infeasible (no runnable surface, missing credentials, docs-only diff).
  2. Agent judgment on authored changes. For commits authored this session that are clearly non-observable (internal plumbing, backend refactors, type-level changes), skip the prompt without asking. The categorical skip list is not exhaustive — the agent trusts its own read of the change it just wrote.

The full decision still runs for cold invocations and ambiguous changes; standalone use is unaffected.


Compound Engineering
Claude Code

Two new short-circuits run before the categorical skip ladder: if the
user explicitly requested evidence, proceed to capture with graceful
fallback; if the agent authored the commits this session and knows the
change is non-observable, skip the prompt without asking. The blocking
prompt was the most expensive step in the workflow and rarely adds
value when the agent already knows the change it just wrote.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4e7a59fc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +197 to +198
1. **User explicitly asked for evidence.** If the user's invocation requested it ("ship with a demo", "include a screenshot"), proceed directly to capture. If capture turns out to be not possible (no runnable surface, missing credentials, docs-only diff) or clearly not useful, note that briefly and proceed without evidence — do not force capture for its own sake.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle provided evidence before forcing new capture

This short-circuit now sends every explicit evidence request directly to ce-demo-reel, which can bypass the existing Use existing evidence path when the user already supplied a valid URL/embed (e.g., “include this screenshot”). In that case, if capture is infeasible (docs-only diff, missing credentials, non-runnable surface), the new flow can proceed without evidence even though reusable evidence was already available, which is a behavior regression from the prior decision ladder.

Useful? React with 👍 / 👎.

@tmchow tmchow merged commit 75cf4d6 into main Apr 23, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
@tmchow tmchow mentioned this pull request Apr 24, 2026
3 tasks
tmchow added a commit that referenced this pull request Apr 24, 2026
PR #663 squash-merged as `feat(ce-commit-push-pr):` — adding two
short-circuits that skip a blocking prompt when the agent just authored
the change. The intent was a UX/flow fix, not a new capability, so the
correct conventional prefix is `fix:`. Since the prefix drove a minor
bump, the open release PR (#661) is pinning the linked `cli` /
`compound-engineering` group at 3.1.0.

This empty commit reclassifies the pending release to 3.0.2 via
`Release-As:` footers so the patch-level fixes in this window
(#660 ce-update, #664 ce-demo-reel, #663 ce-commit-push-pr) land as
3.0.2 instead of 3.1.0. The feat prefix remains in history and may
still render under a Features heading in the generated changelog —
hand-edit the release PR body before merge if so.

Release-As: cli@3.0.2
Release-As: compound-engineering@3.0.2
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant