fix(ce-code-review): move run artifacts from .context/ to /tmp per AGENTS.md#690
Merged
fix(ce-code-review): move run artifacts from .context/ to /tmp per AGENTS.md#690
Conversation
…ENTS.md The repo-root AGENTS.md "Scratch Space" rule (in effect since PR #588 / commit 12aaad3, 2026-04-17) prescribes /tmp as the default for cross-invocation reusable scratch: Cross-invocation reusable: stable path /tmp/compound-engineering/<skill-name>/<run-id>/ -- not mktemp -d -- so later invocations of the same skill can discover sibling run-ids. Use /tmp directly rather than $TMPDIR so paths stay accessible. ce-code-review's per-run artifacts match that profile exactly: per-run-id directory, surfaced in the completion report so the user can grep across runs, not user-curated state. The .context/ usage predated the rule shift and was the only remaining drift in the plugin tree besides ce-optimize. ce-optimize stays under .context/ -- it's the literal example AGENTS.md cites for the user-curated exception (per-spec optimization log surviving across sessions on the same checkout). Touches every reference to the per-run artifact path: - ce-code-review SKILL.md (Stage 4 mkdir, dispatch, Stage 5/6 enrichment, Step 4 artifact emit, mode-specific guidance) - ce-code-review references: subagent-template.md, tracker-defer.md, walkthrough.md - Cross-skill copies of tracker-defer.md (ce-work, ce-work-beta, lfg) that read ce-code-review's artifacts when filing tickets - Generic phrasing tightened in SKILL.md report-only mode and Stage 4 read-only contract (was ".context artifacts" / ".context/ artifact path", now "run artifacts" / "run-artifact path under /tmp/..."). - tests/review-skill-contract.test.ts updated for the new path string and the new generic phrasing. Tests: 908/908 pass. release:validate clean. Surfaced as a follow-up during interactive eval of PR #685. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
michaelvolz
pushed a commit
to michaelvolz/compound-engineering-plugin-windows-version
that referenced
this pull request
Apr 28, 2026
…ENTS.md (EveryInc#690) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ce-code-review's per-run artifacts were being written under
.context/compound-engineering/ce-code-review/<run-id>/, but the repo's AGENTS.md scratch-space rule (in effect since PR #588 / commit 12aaad3, 2026-04-17) defaults that profile to/tmp/compound-engineering/<skill-name>/<run-id>/. This PR aligns ce-code-review with the rule.ce-optimize is intentionally not migrated — it's the example AGENTS.md cites for the user-curated
.context/exception (per-spec optimization log surviving across sessions on the same checkout, with crash-recovery markers and explicit branch-resume semantics). After this PR, ce-optimize is the only place under.context/compound-engineering/in the plugin tree, which matches the AGENTS.md exception list precisely.What changed
8 files, 25 path swaps (all
.context/...→/tmp/...), plus three tightened phrasings:ce-code-review/SKILL.md— Stage 4 mkdir + dispatch artifact paths, Stage 5/6 detail enrichment reads, Step 4 artifact emit, autofix/headless/report-only mode guidance.ce-code-review/references/:subagent-template.md,tracker-defer.md,walkthrough.md.tracker-defer.mdince-work/,ce-work-beta/,lfg/— each reads ce-code-review's per-persona artifacts when filing tickets, so each needed the path swap. (Per AGENTS.md's no-cross-skill-shared-files rule, every skill carries its own copy of the reference.).context/ artifact path→run-artifact path under /tmp/compound-engineering/ce-code-review/<run-id>/;Do not write \.context` artifacts.→Do not write run artifacts.`tests/review-skill-contract.test.tsupdated for the new path string and new generic phrasing.Why this matters
/tmp/compound-engineering/<skill-name>/<run-id>/. ce-code-review's artifacts fit that tier exactly./tmp/users can grep across past runs without those artifacts living inside the repo tree./tmp/compound-engineering/...works on macOS (symlinks to/private/tmp/), Linux, and WSL. Skills here already assume Unix-like shells.Test plan
bun test— 908/908 pass (1 test assertion updated for new path string + generic phrasing).bun run release:validate— clean./ce-code-reviewon a real branch after merge and confirm the completion report's artifact-path line points under/tmp/.References
Surfaced as a follow-up during interactive eval of #685. AGENTS.md scratch-space rule landed in #588.
🤖 Generated with Claude Code