Skip to content

fix(ce-doc-review): rename LFG path to best-judgment to avoid /lfg collision#691

Merged
tmchow merged 1 commit intomainfrom
tmchow/doc-review-best-judgment-rename
Apr 26, 2026
Merged

fix(ce-doc-review): rename LFG path to best-judgment to avoid /lfg collision#691
tmchow merged 1 commit intomainfrom
tmchow/doc-review-best-judgment-rename

Conversation

@tmchow
Copy link
Copy Markdown
Collaborator

@tmchow tmchow commented Apr 26, 2026

Closes #688

Summary

Parallel rename for ce-doc-review, mirroring the LFG → best-judgment rename PR #685 did for ce-code-review (commit 33e00c40). Naming-only change — no behavior shift.

Removes the lexical collision between ce-doc-review's "LFG" routing option and the repo's /lfg macro skill, and replaces "LFG" with descriptive labels that read better to humans.

Key wording choice — "edits" not "fixes"

ce-code-review's option B reads apply per-finding fixes the agent can defend. For ce-doc-review, the natural domain term is "edits" since the action is document edits rather than code patches:

  • Option B: Auto-resolve with best judgment — apply per-finding edits the agent can defend, surface the rest
  • Per-finding option D: Auto-resolve with best judgment on the rest

The internal prose uses "best-judgment path" / "best-judgment routing" — same rationale as ce-code-review: user-facing surface uses "auto-resolve" (descriptive); internal prose uses "best-judgment" (avoids lexical collision with mode:autofix, since autofix is a top-level mode and best-judgment is a routing option within interactive mode).

What changed

File Touchpoints
ce-doc-review/SKILL.md Frontmatter description, prose pointer to bulk-preview
ce-doc-review/references/walkthrough.md Routing option B label, per-finding option D label, all LFG-shaped prose, end-of-walk-through dispatch refs, completion-report path-name section
ce-doc-review/references/bulk-preview.md All three call-site descriptions, scope-summary headers, worked example, Cancel/Proceed semantics, edge cases
ce-doc-review/references/synthesis-and-presentation.md 4 cross-references in the recommended-action mapping
ce-doc-review/references/open-questions-defer.md 1 cross-reference in idempotence rules
tests/pipeline-review-contract.test.ts Label assertions for routing option B and per-finding option D updated

Test plan

  • bun test — 908/908 pass
  • bun run release:validate — clean
  • Final grep for LFG/lfg in ce-doc-review/ and test files returns zero matches

References

🤖 Generated with Claude Code

…llision

Parallel rename for ce-doc-review (closes #688), mirroring PR #685's
33e00c4 commit for ce-code-review. Naming-only change — no behavior
shift.

User-facing labels:

- Routing option B: "LFG. Apply the agent's best-judgment action
  per finding" -> "Auto-resolve with best judgment - apply per-finding
  edits the agent can defend, surface the rest". Picked "edits" over
  "fixes" since ce-doc-review applies document edits, not code patches.
- Per-finding option D: "LFG the rest - apply the agent's best
  judgment to this and remaining findings" -> "Auto-resolve with best
  judgment on the rest". Self-describing, no em-dash needed.
- Bulk-preview header: "LFG plan - N findings:" -> "Auto-resolve plan
  - N findings:" (and the K-already-decided variant).
- SKILL.md frontmatter description: routing-option list updated.

Internal prose:

- "LFG" / "LFG (routing option B)" / "Top-level LFG" ->
  "best-judgment" / "best-judgment routing (option B)" /
  "Top-level best-judgment". Same rationale as ce-code-review's
  rename: user-facing surface uses "auto-resolve" because it
  describes the action; internal prose uses "best-judgment" to avoid
  lexical collision with `mode:autofix` (autofix is a top-level mode;
  best-judgment is a routing option within interactive mode).
- "LFG-the-rest" -> "best-judgment-the-rest" in cross-reference prose.

Files touched:

- plugins/compound-engineering/skills/ce-doc-review/SKILL.md
- plugins/compound-engineering/skills/ce-doc-review/references/walkthrough.md
- plugins/compound-engineering/skills/ce-doc-review/references/bulk-preview.md
- plugins/compound-engineering/skills/ce-doc-review/references/synthesis-and-presentation.md
- plugins/compound-engineering/skills/ce-doc-review/references/open-questions-defer.md
- tests/pipeline-review-contract.test.ts (label assertions updated)

Tests: 908/908 pass. release:validate clean.

Closes #688

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@tmchow tmchow merged commit 50bf65e into main Apr 26, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 26, 2026
michaelvolz pushed a commit to michaelvolz/compound-engineering-plugin-windows-version that referenced this pull request Apr 28, 2026
…llision (EveryInc#691)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename LFG path to best-judgment in ce-doc-review (parallel to PR #685)

1 participant