fix(ce-doc-review): block diagram deletion as a fix recommendation#775
Merged
fix(ce-doc-review): block diagram deletion as a fix recommendation#775
Conversation
Reviewers were silently deleting ASCII diagrams when prose covered the same content, citing "ornamental" or "adds no value over the prose." Diagrams are intentional communication choices that aid spatial comprehension, and they were getting auto-applied as safe_auto fixes even when the underlying issue was a fixable inconsistency (e.g., a 19-vs-20 line-count drift). Two changes: - subagent-template.md FP catalog: visual-aid removal as redundancy is a non-finding. Real inconsistencies (drifted counts, mismatched labels) get a suggested_fix that updates the visual aid; deletion is not eligible at any tier. - synthesis-and-presentation.md safe_auto patterns: replace the prose/diagram-prose-more-detailed wording (which the agent read as license to delete) with prose-vs-diagram inconsistency where the diagram is mechanically updated to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ce-doc-review reviewers were silently deleting ASCII diagrams when the prose covered the same content, citing rationales like "ornamental" or "adds no value over the prose." A real inconsistency in the diagram (e.g., a 19-vs-20 line-count drift) got auto-applied as a deletion via safe_auto, even though the natural fix is to update the count.
The subagent-template false-positive catalog now treats visual-aid removal as redundancy as a non-finding. Real inconsistencies get a
suggested_fixthat updates the visual aid, and deletion is not eligible at any tier. The synthesis safe_auto patterns also replace the prose/diagram-prose-more-detailed wording (which the reviewer read as license to delete) with prose-vs-diagram inconsistency where the diagram is mechanically updated to match.