ci(Mergify): configuration update#124
Conversation
Signed-off-by: UncleSp1d3r <unclesp1d3r@evilbitlabs.io>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThis PR modifies the Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Related Documentation 4 document(s) may need updating based on files changed in this PR: libMagic-rs CI/CD And Merge Queue Configuration — ✅ AcceptedCONTRIBUTING
|
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Mergify configuration generated via the merge protections editor, adjusting CI-related conditions and merge protection thresholds.
Changes:
- Reformats several Mergify conditions (removing quotes / rewrapping long strings).
- Modifies merge protection success conditions for “CI must pass”.
- Tightens the “Do not merge outdated PRs” commits-behind threshold.
| - "title ~= | ||
| ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\\\\(\ | ||
| .+\\\\))?!?:" |
There was a problem hiding this comment.
The conventional-commit protection condition is now split across multiple YAML lines inside a double-quoted string, including a line-continuation escape. This is easy to accidentally break and can change the exact string Mergify evaluates. Consider keeping this condition on a single line (as before) or using a folded scalar (e.g., >-) to make the final evaluated string unambiguous.
| success_conditions: | ||
| - check-success = quality | ||
| - check-success = test | ||
| - "check-success = test-cross-platform (ubuntu-latest, Linux)" | ||
| - "check-success = test-cross-platform (ubuntu-22.04, Linux)" | ||
| - "check-success = test-cross-platform (macos-latest, macOS)" | ||
| - "check-success = test-cross-platform (windows-latest, Windows)" | ||
| - check-success = coverage | ||
|
|
||
| - check-success = test-cross-platform (ubuntu-latest, Linux) | ||
| - check-success = test-cross-platform (macos-latest, macOS) | ||
| - check-success = test-cross-platform (windows-latest, Windows) |
There was a problem hiding this comment.
merge_protections.CI must pass no longer requires the test and coverage checks, and it also dropped the test-cross-platform (ubuntu-22.04, Linux) matrix job. This weakens the protection and allows manual merges that bypass parts of CI (even though the queue still requires them). Add back the missing required checks so the protection matches the intended CI gate.
| description: Make sure PRs are within 10 commits of the base branch before merging | ||
| if: | ||
| - base = main | ||
| success_conditions: | ||
| - "#commits-behind <= 10" | ||
| - "#commits-behind <= 3" |
There was a problem hiding this comment.
The outdated-PR protection now enforces #commits-behind <= 3, but the description still says PRs must be within 10 commits. Either update the description to match the new threshold or revert the threshold change. Also confirm the tighter limit is intended, since it can block merges/queueing more aggressively than before.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Update documentation for #124 _Generated by [Dosu](https://dosu.dev)_ Co-authored-by: dosubot[bot] <131922026+dosubot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: UncleSp1d3r <unclesp1d3r@evilbitlabs.io>
## 🤖 New release * `libmagic-rs`: 0.2.0 -> 0.2.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.2.1] - 2026-03-02 ### Bug Fixes - **mergify**: Exempt release-plz PRs from CI merge protection ([#121](#121)) ### Documentation - **readme**: Use reference-style links for badges ([#128](#128)) ### Miscellaneous Tasks - **Mergify**: Configuration update ([#124](#124)) - **Mergify**: Configuration update ([#126](#126)) - **mergify**: Streamline auto-approval and merging rules for bots <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update documentation for #124 Add a complete CONTRIBUTING.md file with guidelines for developers contributing to libmagic-rs. The guide covers development setup, project architecture, code quality requirements, testing standards, documentation practices, PR submission workflow, style guidelines, and project governance. This provides contributors with clear expectations and processes for participating in the project. _Generated by [Dosu](https://dosu.dev)_ Co-authored-by: dosubot[bot] <131922026+dosubot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This change has been made by @unclesp1d3r from the Mergify merge protections editor.