ci(Mergify): configuration update#89
Conversation
Signed-off-by: UncleSp1d3r <unclesp1d3r@evilbitlabs.io>
|
Caution Review failedFailed to post review comments Summary by CodeRabbit
WalkthroughReconfigures Mergify merge_protections: updates description, restructures success_conditions into nested OR/AND logic (with check-skipped variants for quality, test, test-cross-platform, coverage), and adds a new priority_rules section for bot and bug-fix PR prioritization. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 📃 Configuration Change RequirementsWonderful, this rule succeeded.Mergify configuration change
🟢 CI must passWonderful, this rule succeeded.All CI checks must pass. This protection prevents manual merges that bypass the merge queue.
🟢 Do not merge outdated PRsWonderful, this rule succeeded.Make sure PRs are within 10 commits of the base branch before merging
|
…e04ffb9b99ce0b427 Signed-off-by: UncleSp1d3r <unclesp1d3r@evilbitlabs.io>
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Mergify configuration, focusing on merge protections and adding priority rules for certain PR categories.
Changes:
- Reworks
merge_protectionssuccess conditions to allow “skipped” checks and adds special handling for thetest-cross-platformmatrix. - Adds
priority_rulesfor Dependabot PRs and “bug” PR titles. - Removes the prior merge-queue (
queue_rules) and automation (pull_request_rules) configuration.
Comments suppressed due to low confidence (4)
.mergify.yml:5
- This update removes all
queue_rulesandpull_request_rules, which previously defined the merge queue (squash) and the auto-queuing behavior (approved PRs, release-plz branches, dependabot, anddo-not-mergelabel exclusion). With onlymerge_protections/priority_rulesleft, Mergify likely won’t queue/merge PRs automatically anymore (anddo-not-mergeis no longer enforced). Consider restoring the queue and PR rules (or adding the equivalent actions in the new config) so the repository’s merge flow remains intact.
queue_rules:
- name: default
merge_method: squash
merge_conditions:
- check-success = quality
.mergify.yml:22
- The
test-cross-platformsuccess condition mixes exact matrix check names withcheck-skipped = test-cross-platform. GitHub check names for matrix jobs include the matrix suffix (e.g.test-cross-platform (ubuntu-latest, Linux)), so a barecheck-skipped = test-cross-platformis unlikely to match any skipped check. If you want to support skipped matrix jobs, listcheck-skippedfor each matrix check name (or drop the skipped logic entirely if checks are never path-filtered).
- name: Queue maintainer PRs with lgtm label
conditions:
- base = main
- "author=@maintainers"
- label = lgtm
- label != do-not-merge
actions:
queue:
.mergify.yml:44
- This regex condition looks over-escaped for YAML:
\\(/\\)will typically end up as\\(in the regex, which won’t match conventional-commit titles likebug(scope): .... Prefer a form that yields the intended regex^bug(\(.*\))?:at evaluation time (e.g., adjust backslashes and/or switch to single quotes in YAML) so bug-fix PRs are correctly prioritized.
actions:
review:
type: APPROVE
message: Automatically approved by Mergify
.mergify.yml:5
- The
CI must passdescription mentions checks being “legitimately skipped (path filtering)”, but theCIworkflow jobs referenced here (quality,test,test-cross-platform,coverage) currently run unconditionally on PRs tomain(nopaths:filters). Consider updating the description (and possibly removing thecheck-skippedbranches) to reflect the actual CI behavior.
merge_method: squash
merge_conditions:
- check-success = quality
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This change has been made by @unclesp1d3r from the Mergify Priority Rule Configurator.