Skip to content

Conversation

@obvEve
Copy link
Member

@obvEve obvEve commented Jan 15, 2025

Description

Describe the changes
it removes sex if yes

What is the current behavior? (You can also link to an open issue here)
doesnt remove sex


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@obvEve obvEve added the enhancement New feature or request label Jan 15, 2025
@obvEve obvEve marked this pull request as draft January 15, 2025 17:16
@obvEve
Copy link
Member Author

obvEve commented Jan 15, 2025

tested by french man, doesnt work

@VALERA771
Copy link

It won't work cuz scp sl is started by local admin with own args. So we need to somehow put this args through LA (i don't remember if there is a way) or use other ways

@skyfr0676
Copy link

maybe with exiled loader config ?

@obvEve
Copy link
Member Author

obvEve commented Jan 16, 2025

should be hidden, so exiled loader config doesnt work in this case

@nixkrystik
Copy link

I don't see an issue with this, as LocalAdmin does pass through arguments as long as they start with --. If not, then I'd be interested in why it doesn't.

@obvEve
Copy link
Member Author

obvEve commented Jan 26, 2025

it doesnt, neither me nor yamato had it working

@nixkrystik
Copy link

it doesnt, neither me nor yamato had it working

My best guess as to why it doesn't work is that Exiled is loaded separately to the server application, so environment arguments would be null/empty.

@VALERA771
Copy link

Why we even need to remove it? 💀

@louis1706
Copy link

Why we even need to remove it? 💀

some hosting service wanted a way to remove it i showed than i wasn't against and Nameless did this PR i just said i didn't want an config for it but that would have been fine

@obvEve obvEve marked this pull request as ready for review February 8, 2025 16:21
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work with -- --noeasteregg or -- --defaultloadmessage

@VALERA771 VALERA771 merged commit 6eb4b1e into ExMod-Team:dev Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants