Make failure to lookup Slurm reason description non-fatal #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alas there are a number of omissions in SlurmJobExecutor._REASONS_MAP. Specifically the one we encountered was OutOfMemory, but there are quite a few others missing. Trying to add them all seems not worthwhile. Instead reason lookup has been made robust.
Collaborator
|
Looks like a clear improvement. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alas there are a number of omissions in SlurmJobExecutor._REASONS_MAP. Specifically the one we encountered was OutOfMemory, but there are quite a few others missing. Trying to add them all seems not worthwhile. Instead reason lookup has been made robust.
Fixes #533