[HOLD for payment 2022-10-31] [$250] Payment methods have wrong height - reported by @rushatgabhane

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login
2. Go to Settings -> Payments

Expected Result:

Payment methods have a height of 64px

Actual Result:

Payment methods have a height of 64.5px

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.96-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661196724356509

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

We need to pass styles.lh16 here

App/src/components/MenuItem.js

Line 55 in 85172f7

const descriptionTextStyle = StyleUtils.combineStyles([styles.textLabelSupporting, styles.ml3, styles.mt1, styles.breakAll], props.style);

[flaviadefaria]

Adding the engineering label but doesn't seem like a priority.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@MonilBhavsar Eep! 4 days overdue now. Issues have feelings too...