[HOLD for payment 2022-11-07] [$250] Bug: Android- Firefox the date picker label and placeholder overlaps reported by @thesahindia

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open expensify in Firefox browser on android mobile
2. Go to settings > Workspace > Connect bank account
3. Choose any option and fill the data
4. Check the incorporation date picker at company information step

Expected Result:

label and placeholder shouldn't overlap

Actual Result:

It overlaps

Workaround:

visual

Platform:

Where is this issue occurring?

• Mobile Web - Firefox Android

Version Number: 1.2.17-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665915696977869

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[varshamb]

Proposal

canUseTouchScreen is giving wrong result for Android Firefox.
We could fix canUseTouchScreen but it may not work for other browsers like Opera, Edge etc.

So I think we could remove its dependency to activate the label.

I propose that we should always activate this label for web and mWeb.
I have attached screenshots for the same.

forceActiveLabel={true}

App/src/components/DatePicker/index.js

Lines 71 to 72 in ca501d9

	<TextInput
	forceActiveLabel={!canUseTouchScreen()}

Android Firefox:

Android Chrome:

Web:

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[techievivek]

This can be worked on externally and also @varshamb has already put in a proposal that needs a review.

[melvin-bot]

Triggered auto assignment to @strepanier03 (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.