Investigate which react-native-onyx package caused the deploy blocker

[chiragsalian]

We received this deploy blocked recently. To fix it we reverted the react-native-onyx package here

We need to investigate which PR in that repo caused the problem. I suspect its this one but i haven't confirmed.

Either way, some next steps are,

1. Revert that PR and bump up the react-native-onyx version. Or,
2. Improve that PR and then bump up the react-native-onyx version.

cc @rory, @marcaaron & @Szymon20000 since i see you guys have updated react-native-onyx most recently.

Action Performed:

1. In NewDot pull in version 1.0.24.
2. Run npm i. If react-native-onyx version didn't update in node-modules then delete the folder and rerun npm i.
3. Log into any account. Get its accountID.
4. If its a new account, then message at least two people so that you have some chats on LHN.
5. In psysh run,

use Expensify\Onyx;
use Expensify\OnyxKeys;
Onyx::pushUpdatesToClients([<accountID>], [["onyxMethod" => "mergecollection","key" => "reportIOUs_", "value" => []]]);

7. If you don't have psysh it's a bit harder to simulate. I think you need to go to settings -> workspace -> manage members and add someone you haven't chatted with before.
8. Click into a different tab and come back to newDot's tab.

Expected Result:

1. LHN should continue to look normal.

Actual Result:

1. LHN chats are either empty or show very few of them.

Workaround:

User has to refresh to see their chats.

Platform:

Where is this issue occurring?

• Web
  QA reported it not working on android earlier. I'm unsure and haven't tested the failure elsewhere besides web.

[melvin-bot]

Triggered auto assignment to @slafortune (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[JmillsExpensify]

@chiragsalian I don't see anyone assigned to this issue, so I wanted to clarify how we're handling next steps?

[marcaaron]

I think we just need to go one version at a time and see which one breaks this behavior? I can help look into it.

[chiragsalian]

I don't see anyone assigned to this issue, so I wanted to clarify how we're handling next steps?

Yup i just cc'd relevant people to discuss first. But yes its basically what marc suggested. Btw marc, before going back one version at a time how about just reverting this one and testing? If its not the issue then it would make sense to revert one version at a time.

[marcaaron]

@chiragsalian I am a little confused, but why would running this code trigger the bug?

Onyx::pushUpdatesToClients([<accountID>], [["onyxMethod" => "mergecollection","key" => "reportIOUs_", "value" => []]]);

[chiragsalian]

So i don't know why it triggers the bug but it did. For some reason when updating reportIOUs_, this callback was triggered and it would update reports which is why the LHN list would become empty.

I can demo the behavior to you as well in a video chat if you'd like.

[marcaaron]

Weird.