[IOS] Delete workspace crash

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

I get this crash in the IOS simulator, the crash seems to come from here:

https://github.com/Expensify/react-native-onyx/blob/91aabb7219ddc8722cc2955de0398b1ae70c546d/lib/Onyx.js#L1089

When we get an Onyx update setting a deleted workspace to null.

From the AsyncStorage.multiMerge documentation, it seems like for a pair of key / value, it is expected that the value is a string (stringified JSON).

I'm wondering if we should be calling JSON.stringify on the value if the value is null (JSON.stringify(null) === 'null'). Alternatively, maybe if the value is null we should be clearing the keys from the storage using Storage.multiClear.

Action Performed:

1. Login in IOS
2. Create a workspace
3. Delete the workspace

Expected Result:

Workspace get deleted, no error

Actual Result:

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• iOS

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aimane-chnaif]

related to #10975 (comment)

[aldo-expensify]

Thanks @aimane-chnaif it does look like the same thing. I got the crash while I was testing on this PR: #12129

That PR is fixing that when you delete a workspace with the app closed, once you come back, we send the right policy ids with OpenApp (or ReconnectApp). This makes the server send an onyx update to remove the workspace that wasn't removed when we missed the pusher event.

The exact steps to reproduce would be:

0. Checkout PR Fix removal of deleted workspaces from the client #12129
1. Login in IOS and Web, create a workspace
2. Close the IOS app
3. Delete the workspace using web
4. Wait a few seconds (10?) to miss the pusher event
5. Open the IOS app -> Crash (the server will send policy_xxxxxx = null)

Looking at the backend code, now I see that OpenApp and ReconnectApp will send the policy_xxxxxx = null updates as a merge and not as a set, so I guess that is the bug. Thanks!

[aldo-expensify]

Thanks to @aimane-chnaif I have a good idea on how to fix this in the backend. Taking it internally.

[aldo-expensify]

PR up and ready for review: https://github.com/Expensify/Web-Expensify/pull/35386

[sobitneupane]

@aldo-expensify This issue just reopened. Do you think it is related to this issue? It was previously closed believing it was related to #10975

[aldo-expensify]

@sobitneupane it does look very similar the error and the PR fixing this has not been deployed yet. I'll try to see if I can find more info on the crash to see if it the same.