[HOLD for payment 2022-12-15] [$1000] My own message is prefixed with my name/email at LHN (only for room chats) reported by @thesahindia

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new workspace
2. Search announce room
3. Send a message
4. Observe the LHN message preview

Expected result:

Name/email shouldn't prefixed for your own message like group chats

Actual result:

My own message is prefixed with name/email

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.27-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-11-13.at.11.51.55.PM.mov

**Expensify/Expensify Issue URL:** **Issue reported by:** @thesahindia **Slack conversation:** https://expensify.slack.com/archives/C049HHMV9SM/p1668369685379099 [View all open jobs on GitHub](https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e003307772c7b0fe
• Upwork Job ID: 1597689541572468736

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[daraksha-dk]

Proposal
The lastMessageText logic needs improvement

App/src/libs/SidebarUtils.js

Lines 250 to 252 in e09d228

	let lastMessageText = hasMultipleParticipants && lastActorDetails
	? `${lastActorDetails.displayName}: `
	: '';

Only use displayName as prefix when the current user doesn't match with the last actor
Using hasMultipleParticipants && lastActorDetails && (lastActorDetails.login !== currentUserLogin.email) will solve this

Another solution is to remove current user like this

 const participantsWithoutCurrentUser = _.filter(report.participants, email => email !== currentUserLogin.email);
 const personalDetailMap = OptionsListUtils.getPersonalDetailsForLogins(participantsWithoutCurrentUser, personalDetails);

App/src/libs/SidebarUtils.js

Line 215 in 6209f01

const personalDetailMap = OptionsListUtils.getPersonalDetailsForLogins(report.participants, personalDetails);

[JmillsExpensify]

Echoing my comment in the linked issue, I don't think this is a bug. It's our design. We take the front part of any given email (e.g. ABC123@acme.com) and use that to auto-name the workspace to ABC123. We can look into changing this in the future, though I think this is a feature request for now and we should close the issue.

[thesahindia]

C/P my comment from slack here-

I did some research and I am sure this is a bug. We are getting lastActorDetails from personalDetailMap ( which is accessing report.participants ) if the lastActorDetails is available we prefix the last message with email at LHN if it's not available we will only see the message (without email as prefix) This logic works correctly for group chats because report.participants doesn't contain the current user's details that's why our own message doesn't get prefixed with the email. We are seeing this issue for rooms because for rooms we include the current user's details in report.participants
Code:-

App/src/libs/SidebarUtils.js

Line 250 in 6456bec

let lastMessageText = hasMultipleParticipants && lastActorDetails

App/src/libs/actions/Report.js

Line 69 in 6456bec

if (ReportUtils.isChatRoom(reportNameValuePairs)) {

[JmillsExpensify]

Thanks, for the clarifications! Yes, I agree with you. This is in fact a bug. Marking my earlier comment as outdated.

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

@muttmuure Let's get this one going!

[melvin-bot]

@muttmuure Still overdue 6 days?! Let's take care of this!

[muttmuure]

On it, sorry!

[muttmuure]

I can reproduce - I'm not sure why this is a problem but I follow the logic of the posters above