Console error shows on login Invalid prop ....role of value user supplied to AvatarWithIndicator, expected one of [“admin”]

[flodnv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Launch the app

Expected Result:

Not seeing this console error

Actual Result:

Seeing the console error

Workaround:

Does not seem to affect anything

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669099212581009

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hungvu193]

Proposal
Since we have new role "user" in policies object inside AvatarWithIndicator.js this warning happened.

Solution
To avoid this warning, we can update the AvatarWithIndicator PropTypes by adding new role "user" inside CONST.js.

App/src/CONST.js

Lines 690 to 692 in 6fc1793

	ROLE: {
	ADMIN: 'admin',
	},

    POLICY: {
        TYPE: {
            FREE: 'free',
            PERSONAL: 'personal',
            CORPORATE: 'corporate',
            TEAM: 'team',
        },
        ROLE: {
            ADMIN: 'admin',
+           USER: 'user',
        },
        ROOM_PREFIX: '#',
        CUSTOM_UNIT_RATE_BASE_OFFSET: 100,
        OWNER_EMAIL_FAKE: '_FAKE_',
    },

[flodnv]

Thanks @hungvu193 but this GH does not have the 'Help wanted' label. It was my plan to do this, but another reason I also took it is because we also need another role in there (or else we'll be fixing the same "bug" in a few months).

[davidcardoza]

@flodnv This is what I see when I launch NewDot on web and open the console. Let me know if I am missing a step here, my error doesn't match with the error message in the linked Slack thread.

[flodnv]

@davidcardoza this stumped me for a bit. The logged in user has to be a part of another policy as a user (not admin)

[dhairyasenjaliya]

Hello @flodnv upwork job for bug reporting missing

[flodnv]

Thanks for the bump, can you handle this @davidcardoza please?