[HOLD for payment 2022-12-15] [$1000] Light background colour is shown when navigating between right docked modal pages

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

• Open a right docked page on web or desktop
• Navigate deeper into another right docked modal
• Navigate back and forth between them

Expected Result:

• We shouldn't see an obviously incorrect colour as the background

Actual Result:

• We see an obviously incorrect colour as the background (this existed before, but is much more jarring with the darker colours.)

Platform:

Where is this issue occurring?

• Web
• Desktop App

Reproducible in staging?: yes
Reproducible in production?: yes, pretty soon
Email or phone of affected tester (no customers): all

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f7b6e9d9a74ed27a
• Upwork Job ID: 1598132781569765376

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tienifr]

Proposal

Problem

In

App/src/libs/Navigation/NavigationRoot.js

Line 19 in 1397052

background: themeColors.highlightBG,

we're setting background of navigation is #002E22

Solution

I'm not sure the correct color is, but we can change it In https://github.com/Expensify/App/blob/13970529db79931c2371f7a0b6d5f96792e08c60/src/libs/Navigation/NavigationRoot.js like:

const navigationTheme = {
    ...DefaultTheme,
    colors: {
        ...DefaultTheme.colors,
-        background: themeColors.highlightBG,
+        background: 'transparent',
    },
};

Screen.Recording.2022-11-29.at.17.49.11.mov

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f7b6e9d9a74ed27a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)