Skip to content

GH check reviewerChecklist can fail easily if the reviewer adds something at the top of the comment #13244

@aldo-expensify

Description

@aldo-expensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


It is common to have cases where the reviewerChecklist check fails because something was typed on top of the header ## Reviewer Checklist, for example: #12968 (review)

Action Performed:

  1. A reviewer reviews an App PR adding the checklist, but writes something extra on the top:

Screen Shot 2022-12-01 at 12 34 38 PM

Expected Result:

The reviewerChecklist should pass

Actual Result:

The reviewerChecklist should fails

Screen Shot 2022-12-01 at 9 23 21 AM

Workaround:

Update the comment making sure it starts with ## Reviewer Checklist or just merge and remove the Emergency label

Platform:

N/A

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions