[HOLD for payment 2022-12-20] [$1000] mweb v web inconsistency when you delete a workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with the same account on 2 different devices (Web and mWeb) and open the Workspace tab on each
2. On the second device (Web) open the Workspace
3. On the main device (mWeb) delete Workspace
4. After receiving an error message press the back key on the second device (Web)

Expected Result:

The back key must return to the list of workspace

Actual Result:

The back key closes the sidebar, but does not return to the list of workspace

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.35.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5845404_doc_2022-12-02_19-43-10.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e316b667f840dcf7
• Upwork Job ID: 1599759280513908736

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Puneet-here]

Proposal

We need to pass onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}

App/src/pages/workspace/WorkspaceInitialPage.js

Line 151 in c34e64c

<FullPageNotFoundView shouldShow={_.isEmpty(this.props.policy)}>

To be consistent and fix this at other pages-

1. WorkspaceSettingsPage
   Remove FullPageNotFoundView below since we are using WorkspacePageWithSections which already has FullPageNotFoundView

   App/src/pages/workspace/WorkspaceSettingsPage.js

   Line 75 in 7fd49bd

   <FullPageNotFoundView shouldShow={_.isEmpty(this.props.policy)}>

at WorkspacePageWithSections remove shouldShowBackButton={false} and pass onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}

App/src/pages/workspace/WorkspacePageWithSections.js

Line 109 in 5c21935

<FullPageNotFoundView shouldShowBackButton={false} shouldShow={_.isEmpty(this.props.policy)}>

2. WorkspaceInvitePage
   Pass onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)} below
   

   App/src/pages/workspace/WorkspaceInvitePage.js

   Line 255 in 5c21935

   <FullPageNotFoundView shouldShow={_.isEmpty(this.props.policy)}>

3. WorkspaceMembersPage
   Same here

   App/src/pages/workspace/WorkspaceMembersPage.js

   Line 321 in 5c21935

   <FullPageNotFoundView shouldShow={_.isEmpty(this.props.policy)}>

My second thoughts are that the user should only get navigated to workspaces section when they are at initial settings page when they press back on other pages (WorkspaceMembersPage/WorkspaceSettingsPage) they will expect to get navigated at initial settings page and when pressing back at WorkspaceInvitePage they will expect to be navigated to WorkspaceMembersPage so we should keep shouldShowBackButton={false} at WorkspacePageWithSections and we should add it to FullPageNotFoundView at WorkspaceInvitePage and WorkspaceMembersPage

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[situchan]

Proposal

Root cause:
onBackButtonPress prop not set here so default value is applied

App/src/pages/workspace/WorkspaceInitialPage.js

Line 151 in c34e64c

<FullPageNotFoundView shouldShow={_.isEmpty(this.props.policy)}>

Solution:

-               <FullPageNotFoundView shouldShow={_.isEmpty(this.props.policy)}>
+               <FullPageNotFoundView onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)} shouldShow={_.isEmpty(this.props.policy)}>

We need to apply this fix to all pages using FullPageNotFoundView:
WorkspaceInvitePage
WorkspaceMembersPage
WorkspaceSettingsPage
onBackButtonPress is missing on these pages

(While I am finding all similar issues throughout the app, @Puneet-here posted proposal)

[s77rt]

Proposal

diff --git a/src/components/BlockingViews/FullPageNotFoundView.js b/src/components/BlockingViews/FullPageNotFoundView.js
index 84014c43d1..3fe080b0f4 100644
--- a/src/components/BlockingViews/FullPageNotFoundView.js
+++ b/src/components/BlockingViews/FullPageNotFoundView.js
@@ -42,7 +42,7 @@ const defaultProps = {
     subtitleKey: 'notFound.pageNotFound',
     shouldShowBackButton: true,
     shouldShowCloseButton: true,
-    onBackButtonPress: () => Navigation.dismissModal(),
+    onBackButtonPress: () => Navigation.goBack(),
 };
 
 // eslint-disable-next-line rulesdir/no-negated-variables

Details

Changed the default behaviour of the back button on FullPageNotFoundView to Navigation.goBack()

[arosiclair]

Familiar with this so I can help manage if this passes BZ checks

[laurenreidexpensify]

• can reproduce ✔️
• this is a bug ✔️
• not a dupe ✔️
• write up instructions are good ✔️
• renamed to make title more clear ✔️