Skip to content

Fix broken UnreadIndicatorsTest #14352

@roryabraham

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

This PR broke the UnreadIndicatorsTest. It did not get flagged on the PR because the test was not run for some reason (treating this as a separate problem and planning to deal with it by completing #14088 before creating another issue).

Solution

This test is failing because local notifications used to be triggered by Onyx updates, but #14224 changes that so they are triggered by Pusher events, which trigger both a notification and an Onyx update.

However, UnreadIndicatorsTest is currently structured only to mock Onyx data updates, not Pusher events. We need to change that so it mocks Pusher events instead.

View all open jobs on GitHub

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions