[HOLD for payment - C+ only] [$1000] Workspace - Remove button is displayed active upon selecting admin to be deleted from workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1, Login to NewDot
2. Go to Workspace -> Members -> Invite
3. Select admin account

Expected Result:

Remove button should not look active

Actual Result:

Remove button is displayed active upon selecting admin to be deleted from workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6091696_video_58.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b6a900eb33013827
• Upwork Job ID: 1669443164980342784
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In workspace members page, the remove button is active when admin/logged in user is selected for removal which is not allowed.

What is the root cause of that problem?

The remove button is disabled only when there are no selected members. The condition for checking if admin/logged in user is selected is not added.

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 454 to 461 in b089bde

	<Button
	medium
	danger
	style={[styles.ml2]}
	isDisabled={this.state.selectedEmployees.length === 0}
	text={this.props.translate('common.remove')}
	onPress={this.askForConfirmationToRemove}
	/>

What changes do you think we should make in order to solve the problem?

We need to add a new condition here to disable the button when either the logged in user or admin or both are selected. For that, we can use the following condition -

isDisabled={this.state.selectedEmployees.length === 0 || _.some(this.state.selectedEmployees, member => member === this.props.policy.owner || member === this.props.session.email)}

We can create a new function for this to make it more readable.

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

Currently, We are facing this bug. My proposal will work well after this issue is resolved

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Remove button is displayed active upon selecting admin to be deleted from workspace

What is the root cause of that problem?

App/src/pages/workspace/WorkspaceMembersPage.js

Line 458 in 23978e4

isDisabled={this.state.selectedEmployees.length === 0}

We are checking that if this.state.selectedEmployees.length === 0 we will disable the remove button

What changes do you think we should make in order to solve the problem?

We also should disable remove button if there is any error like that

   isDisabled={(this.state.selectedEmployees.length === 0) || !_.isEmpty(this.state.errors)}

It is similar to the check we did when clicking the remove button

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 197 to 200 in 862955c

	askForConfirmationToRemove() {
	if (!_.isEmpty(this.state.errors)) {
	return;
	}

Result

Screen.Recording.2023-06-14.at.14.32.15.mov

[NicMendonca]

@kbecciv just to confirm, under the Expected Result you say that the remove should look active, but it should be that it should not display as active?

[kbecciv]

@NicMendonca Corrected, sorry for confusion

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b6a900eb33013827

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.