[HOLD for payment 2023-07-14] [$1000] Bank Account – Icon on the left of “secure your account” in “validate bank account” section is not turning white like others when hovered.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open "Settings".
2. Click "Workspaces".
3. Click "Bank Account".
4. Click " Connect bank account".
5. Complete all steps until you reach the last step “Validate bank account”.

Expected Result:

Icon on the left of “secure your account” in “validate bank account” section should turn white like others when hovered.

Actual Result:

Icon on the left of “secure your account” in “validate bank account” section is not turning white like others when hovered.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

3a.mp4

3.1.mp4

Recording.4979.mp4

Expensify/Expensify Issue URL:

Issue reported by: @usmantariq96

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686379821898329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c9d2073930803828
• Upwork Job ID: 1670808482132348928
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shield icon in “validate bank account” section doesn't have hover effect

What is the root cause of that problem?

We're supplying iconFill color of Shield icon here which makes the color of this icon always is success color

App/src/pages/ReimbursementAccount/Enable2FAPrompt.js

Line 32 in 4c1739b

iconFill: themeColors.success,

What changes do you think we should make in order to solve the problem?

We only need to remove iconFill here to make the color of icon is not constant

App/src/pages/ReimbursementAccount/Enable2FAPrompt.js

Line 32 in 4c1739b

iconFill: themeColors.success,

What alternative solutions did you explore? (Optional)

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover colour of shield icon is not white

What is the root cause of that problem?

The root cause of the issue is that we're explicitly supplying a fill colour here.

What changes do you think we should make in order to solve the problem?

We just need to remove this line so that the fill colour is no longer defined explicitly.

What alternative solutions did you explore? (Optional)

None

[allroundexperts]

FYI, I posted the solution earlier here.

[gadhiyamanan]

FYI, I posted the solution earlier here.

@allroundexperts i think only bug reporter can propose a solution in slack

[allroundexperts]

FYI, I posted the solution earlier here.

@allroundexperts i think only bug reporter can propose a solution in slack

Oh, I did not know that @gadhiyamanan. Is this written somewhere?

[allroundexperts]

Posted about this here.

[gadhiyamanan]

According to CONTRIBUTING.md reporter may optionally propose a solution for that job on Slack and it will be reviewed in GitHub.