[Awaiting payment] New Chat report is always created even after a chat report already exists

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the plus sign at the bottom of the screen.
2. Select "New Chat" and search for a new email.
3. Observe that the Concierge notification message appears in the new message.
4. Search for the same email again and enter it, and observe that the Concierge notification message disappears.

Expected Result:

The Concierge notification should appear when we go to a new chat and when we search for the same email again.

Actual Result:

The Concierge notification appears when we go to a new chat, but disappears when we search for the same email again.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30.0

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

screen-capture.33.webm

Recording.3182.mp4

Expensify/Expensify Issue URL:

Issue reported by: @tewodrosGirmaA

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687330135172719

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

I think this is incorrect logic when creating new chats. It should not create a new chat in this case.

[mountiny]

Cant get the concierge whisper message locally

[mountiny]

I had to use completely new account with different domain to reproduce

[mountiny]

Confirmed now that this issue seems to be related to Web changes, it works fine on main with production API and it breaks on main or staging API.

[mountiny]

This is a response I am getting when creating the duplicate chat

{
    "jsonCode": 408,
    "title": "Session expired",
    "message": "The account you are trying to use is deleted.",
    "requestID": "U2NJcy",
    "onyxData": []
}

Open report Form data of the failed request

And the original correct request:

And the response

And it seems to be returned twice 🤔

[mountiny]

Then using the production API:

And personal details are

[mountiny]

Alright so it seems like the issue is that staging and main API are only returning accountID, displayName and avatar