[HOLD for payment 2023-10-30] [HOLD #25714] Split bill - App crashes when splitting bill in group with both expensifail and gmail accounts

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #20838

Action Performed:

1. Login to NewDot
2. Create a group with several gmail and expensifail accounts
3. Go to created group chat
4. Tap + and create a split bill for the whole group

Expected Result:

Successful Split Bill

Actual Result:

App crashes (Android)
App freezes (Web, mWeb)
Error message when creating split bill (iOS)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video_13.mp4

Pronin.crash.2106.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

@aldo-expensify if it helps, I see these logs in crashlytics:

Non-fatal Exception: io.invertase.firebase.crashlytics.JavaScriptError: array list[1] is not type String
       at .stringListFromIterable(address at index.android.bundle:1:5688527)
       at .anonymous(address at index.android.bundle:1:5690123)
       at .arrayToString(address at index.android.bundle:1:1847665)
       at .createSplitsAndOnyxData(address at index.android.bundle:1:2878809)
       at .splitBill(address at index.android.bundle:1:2881501)
       at .anonymous(address at index.android.bundle:1:2671772)
       at .onConfirm(address at index.android.bundle:1:2672957)
       at .anonymous(address at index.android.bundle:1:2767405)
       at .onPress(address at index.android.bundle:1:2767806)
       at .onPress(address at index.android.bundle:1:2770537)
       at .onPress(address at index.android.bundle:1:1725618)
       at .anonymous(address at index.android.bundle:1:1839331)
       at ._performTransitionSideEffects(address at index.android.bundle:1:416247)
       at ._receiveSignal(address at index.android.bundle:1:415835)
       at .onResponderRelease(address at index.android.bundle:1:414649)
       at .apply((native):0:0)
       at .invokeGuardedCallbackImpl(address at index.android.bundle:1:337841)
       at .apply((native):0:0)
       at .invokeGuardedCallback(address at index.android.bundle:1:337898)
       at .apply((native):0:0)
       at .invokeGuardedCallbackAndCatchFirstError(address at index.android.bundle:1:337930)
       at .executeDispatch(address at index.android.bundle:1:338062)
       at .executeDispatchesAndReleaseTopLevel(address at index.android.bundle:1:342319)
       at .forEach((native):0:0)
       at .forEachAccumulated(address at index.android.bundle:1:339560)
       at .anonymous(address at index.android.bundle:1:342671)
       at .batchedUpdatesImpl(address at index.android.bundle:1:401877)
       at .batchedUpdates(address at index.android.bundle:1:342239)
       at ._receiveRootNodeIDEvent(address at index.android.bundle:1:342512)
       at .receiveTouches(address at index.android.bundle:1:396657)
       at .apply((native):0:0)
       at .__callFunction(address at index.android.bundle:1:139406)
       at .anonymous(address at index.android.bundle:1:137771)
       at .__guard(address at index.android.bundle:1:138724)
       at .callFunctionReturnFlushedQueue(address at index.android.bundle:1:137729)

[aldo-expensify]

I got this on web:

The error looks similar to the one above.

[aldo-expensify]

The gmail participants of the group have login: undefined:

I find it strange because these are accounts that existed in my database (I created them before creating the group)

The code crashes around here:

App/src/libs/actions/IOU.js

Line 462 in 1745b01

const formattedParticipants = Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login)]);

These accounts have missing the login in the OpenApp response:

I think that's because I didn't have chats between these accounts before creating the group.

[aldo-expensify]

Asking in slack about expected behaviour: https://expensify.slack.com/archives/C03TQ48KC/p1687387011143229

[aldo-expensify]

Considering this, this is not a deploy blocker anymore.