[HOLD for C+ newdot payment] [$1000] Web - Bank - Error message 'bank account should end with 1111' disappears after blurring the routing number input field

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Workspace > Bank account > Connect with plaid method > Chase Bank
3. Use the following credentials for Chase Bank
   Username: user_good
   Password: pass_good
4. If a verification is prompted - select mobile and enter "credentials_good" as the verification mode
5. Checkmark the "Plaid Checking" and "Plaid Saving" and the last 2 options.
6. Click on continue
7. Check the T&C and click "Connect account information"
8. Click on the last confirmation on the plaid modal
9. Select the bank account ending in 1111
10. Enter Routing Number: 011401533 an enter an incorrect bank account number (e.g 1111222233334444)
11. Blur or take the focus away from the routing number input field by clicking outside of it or switching the tabs.

Expected Result:

The error message 'Your account number should end with 1111' should not disappear

Actual Result:

The error message 'Your account number should end with 1111' disappears after switching tab. The issue is still reproduced after the page is refreshed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34.1

Reproducible in staging?: Yes

Reproducible in production?: N/A

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6110088_bandicam_2023-06-29_03-57-25-088.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01964ffb3d42e77df4
• Upwork Job ID: 1674308097839382528
• Last Price Increase: 2023-08-10
• Automatic offers:
• hungvu193 | Contributor | 26383005

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Bank - Error message 'bank account should end with 1111' disappears after switching tab

What is the root cause of that problem?

We always call validate function again when ever input is blurred:

App/src/components/Form.js

Lines 287 to 295 in 5997357

	onBlur: (event) => {
	// We delay the validation in order to prevent Checkbox loss of focus when
	// the user are focusing a TextInput and proceeds to toggle a CheckBox in
	// web and mobile web platforms.
	setTimeout(() => {
	setTouchedInput(inputID);
	onValidate(inputValues);
	}, 200);

Let take a look at our onValidate function, as we can see it always clear the server error which caused this issue:

App/src/components/Form.js

Line 117 in 5997357

FormActions.setErrors(props.formID, null);

What changes do you think we should make in order to solve the problem?

That make senses to clear server errors when input changed but when input is blurred we should keep the server errors.
So we will need to create a new variable called hasServerErrors:

const hasServerError = useMemo(() => Boolean(props.formState) && !_.isEmpty(props.formState.errors), [props.formState]);

Also update our onValidate function with a new param called shouldClearServerError default value is true and we only clear server errors when shouldClearServerError equals true.

    const onValidate = useCallback(
        (values, shouldClearServerError = true) => {
      // other codes
            if (shouldClearServerError) {
                FormActions.setErrors(props.formID, null);
            } 

Finally update our onBlur function (don't forget to add hasServerError in the dependencies list)

                    onBlur: (event) => {
                        // We delay the validation in order to prevent Checkbox loss of focus when
                        // the user are focusing a TextInput and proceeds to toggle a CheckBox in
                        // web and mobile web platforms.
                        setTimeout(() => {
                            setTouchedInput(inputID);
                            onValidate(inputValues, !hasServerError);
                        }, 200);

What alternative solutions did you explore? (Optional)

If we can synchronize the validation of account number between client and server then we can avoid this issue.

Result:

Screen.Recording.2023-06-29.at.07.18.43.mov

[kadiealexander]

Repro'd:

2023-06-29_18-45-00.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01964ffb3d42e77df4

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)