[HOLD for payment 2023-07-28] [$1000] Web - Still old Thread message is shown on the public room even after deletion

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1.Go to staging dot on web chrome
2. Create a new room in public mode
3. Go to room header, copy the URL
4. Now send a message on the room (let's say hello). Then click on reply thread so that a new thread page opens up and send a new message.
5. Now open an incognito window and paste the room URL copied earlier
6. On Incognito window, click on "1 Reply thread" of the User's A 'hello' message so that a thread page appears
7. Now from User A, delete the original message (hello in our case)
8. On incognito window, again go to the thread page and notice that 'deleted message' appears everywhere but is not updated on the bottom area. But if you refresh the page, it updates properly.

Expected Result:

'Deleted message' should be shown on the public room

Actual Result:

Old thread message is shown on the thread page of the room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-07-02_14.40.33.mp4

Recording.3383.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688288249670349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012822a83fb249af39
• Upwork Job ID: 1676277777324867584
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report thread name in the anonymous report footer doesn't update when we delete the thread.

What is the root cause of that problem?

The report footer uses AvatarWithDisplayName to show the avatar and the name.

App/src/components/AvatarWithDisplayName.js

Line 56 in 917c344

const title = props.isAnonymous ? props.report.displayName : ReportUtils.getDisplayNameForParticipant(props.report.ownerAccountID, true);

If isAnonymous is true, we use report.displayName as the title. The problem is, displayName is a local property that is set when SidebarLink (LHN) is rendered. On each render, SidebarLink will call getOrderedReportIDs that will run below logic.

App/src/libs/SidebarUtils.js

Lines 137 to 143 in 917c344

	// There are a few properties that need to be calculated for the report which are used when sorting reports.
	_.each(reportsToDisplay, (report) => {
	// Normally, the spread operator would be used here to clone the report and prevent the need to reassign the params.
	// However, this code needs to be very performant to handle thousands of reports, so in the interest of speed, we're just going to disable this lint rule and add
	// the reportDisplayName property to the report object directly.
	// eslint-disable-next-line no-param-reassign
	report.displayName = ReportUtils.getReportName(report);

As you can notice, we are mutating the report object by adding displayName property. The comment explains why they do that. So, even though the SidebarLink is re-rendered (because the report changes) when we delete the thread from another client, the report footer still has the old displayName because displayName is a property that needs to be updated inside getOrderedReportIDs and it won't notify any Onyx subscriber about the changes.

What changes do you think we should make in order to solve the problem?

We shouldn't depend on displayName of report, instead we should get the name/title by using ReportUtils.getReportName.

Details:

App/src/components/AvatarWithDisplayName.js

Line 56 in 917c344

const title = props.isAnonymous ? props.report.displayName : ReportUtils.getDisplayNameForParticipant(props.report.ownerAccountID, true);

Replace props.report.displayName with ReportUtils.getReportName(props.report)

We did this to show the title of LHN items.

App/src/libs/SidebarUtils.js

Lines 372 to 374 in 917c344

	const reportName = ReportUtils.getReportName(report);
	result.text = reportName;

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012822a83fb249af39

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[zanyrenney]

hey @0xmiroslav what do you think of the proposal above from @bernhardoj ?