[HOLD for payment 2023-07-17] [$1000] Web- Eye icon position not aligned and nothing happen on click of eye icon

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Click on + icon and select Add attachment option
3. Select password protected PDF
4. Click on enter password button
5. Click on eye icon

Expected Result:

Should show password on click of eye icon

Actual Result:

Eye icon position not aligned and nothing happen on click of eye icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-2
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-04.at.4.57.49.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688470270928489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0175d4f2d46ea957ec
• Upwork Job ID: 1676995758027735040
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Eye icon position is not aligned and nothing happens on click of eye icon in password protected PDF form.

What is the root cause of that problem?

styles.flex1 was removed from the container of eye icon in this PR which is why the icon is not in center anymore.

App/src/components/TextInput/BaseTextInput.js

Lines 348 to 360 in 3e0d7dd

	{Boolean(props.secureTextEntry) && (
	<Checkbox
	style={styles.textInputIconContainer}
	onPress={togglePasswordVisibility}
	onMouseDown={(e) => e.preventDefault()}
	accessibilityLabel={props.translate('common.visible')}
	>
	<Icon
	src={passwordHidden ? Expensicons.Eye : Expensicons.EyeDisabled}
	fill={themeColors.icon}
	/>
	</Checkbox>
	)}

Nothing happens on clicking of eye icon since we are calling the setPasswordHidden in togglePasswordVisibility in the wrong way. prevState is not an object but is instead the current value of passwordHidden.

App/src/components/TextInput/BaseTextInput.js

Lines 220 to 222 in 3e0d7dd

	const togglePasswordVisibility = useCallback(() => {
	setPasswordHidden((prevState) => !prevState.passwordHidden);
	}, []);

What changes do you think we should make in order to solve the problem?

We need to add styles.flex1 again in line 350 -

style={[styles.flex1, styles.textInputIconContainer]}

For fixing the click behaviour of eye icon, we need to call setPasswordHidden in the correct way in togglePasswordVisibility by not using prevState.passwordHidden and directly using prevState -

We need to simply call it like -

const togglePasswordVisibility = useCallback(() => { 
   setPasswordHidden((prevState) => !prevState); 
}, []); 

We can change the name of variable prevState to something else for better understanding.

What alternative solutions did you explore? (Optional)

NA

Result -

Screen.Recording.2023-07-04.at.8.50.55.PM.mov

[Nikhil-Vats]

This is a regression from #20186.