[HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] Web - Workspace avatar is not updating after renaming

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a new account
2. Click on FAB > new workspace > Rename the workspace
3. Do step 2 again and notice the announce room vs the admin room avatars

Expected Result:

Both announce room and admin room avatar should change at the same time to reflect the renamed workspace

Actual Result:

Only admin changes and announce room avatar doesn't update

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3762.mp4

2023-07-19.22.27.03.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689794502432149

View all open jobs on GitHub

[kbecciv]

For mWeb both admin and announce rooms avatars don't update

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Admin and announce room avatar are not updated after renaming workspace

What is the root cause of that problem?

This issue is from this PR
We don't get option data when policy changes as you can see below(no dependency)

App/src/components/LHNOptionsList/OptionRowLHNData.js

Lines 58 to 66 in fa473e9

	const optionItem = useMemo(() => {
	// Note: ideally we'd have this as a dependent selector in onyx!
	const item = SidebarUtils.getOptionData(fullReport, personalDetails, preferredLocale);
	if (deepEqual(item, optionItemRef.current)) {
	return optionItemRef.current;
	}
	optionItemRef.current = item;
	return item;
	}, [fullReport, preferredLocale, personalDetails]);

For admin report, the lastMessageText of the report is changed and so the useMemo is calculated again, but this is not the case for announce report.

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to add policy as dependency for policy reports.
The code would look like

    const policy = lodashGet(policies, [`${ONYXKEYS.COLLECTION.POLICY}${fullReport.policyID}`], '');

    const optionItemRef = useRef();
    const optionItem = useMemo(() => {
        // Note: ideally we'd have this as a dependent selector in onyx!
        const item = SidebarUtils.getOptionData(fullReport, personalDetails, preferredLocale);
        if (deepEqual(item, optionItemRef.current)) {
            return optionItemRef.current;
        }
        optionItemRef.current = item;
        return item;
    }, [fullReport, preferredLocale, personalDetails, policy]);

Add the following keys to withOnyx

            policies: {
                key: ONYXKEYS.COLLECTION.POLICY
            },

This works perfect

What alternative solutions did you explore? (Optional)

[jasperhuangg]

It looks like a regression from #21406. I think we should have the PR's original author @hannojg fix it

[francoisl]

Sounds good, hopefully @hannojg can chime in, otherwise @s-alves10 's proposal above makes sense and works well for me.

[fedirjh]

I am looking at this.