[$1000] Web - Reply in thread on messages in 'owes' or 'paid' money reports does not have 'From' link in header

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report and on any message, hover and click on reply in thread
3. Observe in header, it displays 'From' link to parent thread
4. Request money from any user, in their report, open 'owes' report and add any message
5. Hover on message and click on reply in thread, observe that now it does not display 'From' link to parent thread in header

Expected Result:

App should display 'From' link to parent thread in reply in thread report

Actual Result:

App does not display 'From' link to parent thread when we reply in thread to a message from 'owes' or 'paid' money reports

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

reply.in.thread.owes.and.paid.report.mp4

Recording.3877.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690170723345019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01de8189e72eaa3fa3
• Upwork Job ID: 1683899690476761088
• Last Price Increase: 2023-07-25
• Automatic offers:
• fedirjh | Reviewer | 25913761
• StevenKKC | Contributor | 25913762
• dhanashree-sawant | Reporter | 25913764

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reply in thread on messages in 'owes' or 'paid' money reports does not have 'From' link in header.

What is the root cause of that problem?

From link is displayed by parentNavigationSubtitle in HeaderView.

App/src/pages/home/HeaderView.js

Line 93 in ff54c9e

const parentNavigationSubtitle = ReportUtils.getParentNavigationSubtitle(reportHeaderData);

App/src/pages/home/HeaderView.js

Lines 192 to 208 in ff54c9e

	{!_.isEmpty(parentNavigationSubtitle) && (
	<PressableWithoutFeedback
	onPress={() => {
	Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID));
	}}
	style={[styles.alignSelfStart, styles.mw100]}
	accessibilityLabel={parentNavigationSubtitle}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK}
	>
	<Text
	style={[styles.optionAlternateText, styles.textLabelSupporting, styles.link]}
	numberOfLines={1}
	>
	{parentNavigationSubtitle}
	</Text>
	</PressableWithoutFeedback>
	)}

But ReportUtils.getParentNavigationSubtitle returns empty string for iou report, because iou report does not have displayName field.

App/src/libs/ReportUtils.js

Lines 1251 to 1262 in ff54c9e

	function getParentNavigationSubtitle(report) {
	if (isThread(report)) {
	const parentReport = lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]);
	const {rootReportName, workspaceName} = getRootReportAndWorkspaceName(parentReport);
	if (_.isEmpty(rootReportName)) {
	return '';
	}
	return Localize.translateLocal('threads.parentNavigationSummary', {rootReportName, workspaceName});
	}
	return '';
	}

App/src/libs/ReportUtils.js

Lines 1197 to 1219 in ff54c9e

	function getRootReportAndWorkspaceName(report) {
	if (isChildReport(report) && !isMoneyRequestReport(report)) {
	const parentReport = lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]);
	return getRootReportAndWorkspaceName(parentReport);
	}
	if (isIOUReport(report)) {
	return {
	rootReportName: lodashGet(report, 'displayName', ''),
	};
	}
	if (isMoneyRequestReport(report)) {
	return {
	rootReportName: lodashGet(report, 'displayName', ''),
	workspaceName: isIOUReport(report) ? CONST.POLICY.OWNER_EMAIL_FAKE : getPolicyName(report, true),
	};
	}
	return {
	rootReportName: getReportName(report),
	workspaceName: getPolicyName(report, true),
	};
	}

So the report does not have From link in header.

What changes do you think we should make in order to solve the problem?

We can return the report name for iou reports and money request reports.

    if (isIOUReport(report)) {
        return {
-           rootReportName: lodashGet(report, 'displayName', ''),
+           rootReportName: getReportName(report),
        };
    }

    if (isMoneyRequestReport(report)) {
        return {
-           rootReportName: lodashGet(report, 'displayName', ''),
+           rootReportName: getReportName(report),
            workspaceName: isIOUReport(report) ? CONST.POLICY.OWNER_EMAIL_FAKE : getPolicyName(report, true),
        };
    }

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01de8189e72eaa3fa3

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[CortneyOfstad]

@fedirjh Thoughts on the proposal above?

[fedirjh]

@StevenKKC This looks like a recen regression, why report doesn’t have displayName ?