[HOLD for payment 2023-08-10] [$1000] Long emoji names are not being truncated and icons displayed at the start

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Preferences.
2. Select Spanish language.
3. Go back and open a chat.
4. Type ":pist" in the chat
5. Observe that the emoji icons are not at their positions

Expected Result:

Long emoji names should be broken into multiple lines (so the entire name is visible), and should appear in the same position as other emojis).

Actual Result:

Long emojis names are not being truncated that cause the icons not displayed at the their position

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690043682464129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01245a38493bcc690f
• Upwork Job ID: 1683941474981871616
2023-07-25
• Automatic offers:
• hungvu193 | Contributor | 25816031

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long emoji suggestions doesn't show ellipsis, instead they are cut off

What is the root cause of that problem?

Emoji suggestion style has no text ellipsis feature

App/src/styles/styles.js

Lines 199 to 201 in b7d17e0

	emojiSuggestionsText: {
	fontSize: variables.fontSizeMedium,
	},

What changes do you think we should make in order to solve the problem?

We have 2 options: ellipsis and multiline

1. Add flexShrink: 0 to the emojiSuggestionsEmoji style to prevent the shrink
2. Add the following styles to the emojiSuggestionsText style in each case

Ellipsis

    flexShrink: 1,
    ...spacing.mr2,

Add two props below

App/src/components/EmojiSuggestions.js

Line 72 in 2b67fa3

<Text style={styles.emojiSuggestionsText}>

    <Text style={styles.emojiSuggestionsText} numberOfLines={1} ellipsizeMode='tail'>

Multiline

    flexShrink: 1,
    ...spacing.mr2,
    ...wordBreak.breakAll

This works fine.

android

web

What alternative solutions did you explore? (Optional)

We can apply similar styles with mention suggestions
Add styles.ph2 to the EmojiSuggestion container style

App/src/components/EmojiSuggestions.js

Line 70 in b7d17e0

<View style={styles.autoCompleteSuggestionContainer}>

Set width:24 in the emojiSuggestionsEmoji style

App/src/styles/styles.js

Lines 194 to 198 in b7d17e0

	emojiSuggestionsEmoji: {
	fontSize: variables.fontSizeMedium,
	width: 51,
	textAlign: 'center',
	},

Add the following styles to the emojiSuggestionsText style

    marginLeft: 8,
    overflow: 'hidden',
    textOverflow: 'ellipsis',
    whiteSpace: 'nowrap',

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long emoji names are not being truncated and icons displayed at the start

What is the root cause of that problem?

We didn't define a width for our emoji text which cause the issue.

App/src/styles/styles.js

Lines 204 to 206 in 6e6d2bd

	emojiSuggestionsText: {
	fontSize: variables.fontSizeMedium,
	},

What changes do you think we should make in order to solve the problem?

We should add width: "100%" or flex: 1 to the emojiSuggestionsText.

    emojiSuggestionsText: {
     // we can also add some padding right here to make it symmetrical with the left.
       fontSize: variables.fontSizeMedium,
        flex: 1,
        paddingRight: 10,
        ...wordBreak.breakWord,
    },

What alternative solutions did you explore? (Optional)

N/A

Result:

Screen.Recording.2023-07-26.at.06.52.36.mov

[jfquevedol2198]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long emoji names are not being truncated and icons displayed at the start

What is the root cause of that problem?

App/src/components/EmojiSuggestions.js

Line 72 in b7d17e0

<Text style={styles.emojiSuggestionsText}>

numberOfLines of Text in this line is not specified and styles are not correct.

What changes do you think we should make in order to solve the problem?

We can do same like MentionSuggestions

1. Update these lines as follows:

 <View style={[styles.autoCompleteSuggestionContainer, styles.ph2]}>
    <Text style={styles.emojiSuggestionsEmoji}>{EmojiUtils.getEmojiCodeWithSkinColor(item, props.preferredSkinToneIndex)}</Text>
    <Text style={[styles.emojiSuggestionsText, styles.flex1]}>

2. Styles Update:

    emojiSuggestionsEmoji: {
        fontSize: variables.fontSizeMedium,
        width: variables.fontSizeMedium,
        textAlign: 'center',
    },
    emojiSuggestionsText: {
        fontSize: variables.fontSizeMedium,
        ...spacing.ml2,
        ...wordBreak.breakAll
    },

Android

iOS

Web

mWeb - Chrome

mWeb - Safari

What alternative solutions did you explore? (Optional)

1. Update this line as follows:

    <Text style={[styles.emojiSuggestionsText, styles.flex1, styles.pr4]}>

2. Styles Update:

    emojiSuggestionsText: {
        fontSize: variables.fontSizeMedium,
        ...wordBreak.breakAll
    },

[joekaufmanexpensify]

Reproduced. Though, I don't think we'd truncate the emojis that don't fit on one line. We should break them onto a second line (like we do for these same emojis in the android native app).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01245a38493bcc690f

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.