[HOLD for payment 2023-08-16] [$1000] Web - Task - Error is shown as soon as app is put in background when creating a task

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the testing app
2. Open any chat
3. Click on the + icon and select Assign task
4. Put the desktop app in background (navigate to another another open app or desktop)
5. Put the app back in foreground

Expected Result:

No error message in the title field to appear since user have not clicked on next/continue button yet

Actual Result:

Error message appear in the task title field once app is brought back to foreground

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6140912_Screen_Recording_2023-07-25_at_1.45.31_PM.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f687ec29289cd8a
• Upwork Job ID: 1684312907864506368
2023-07-26
• Automatic offers:
• tienifr | Contributor | 25860865

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Not sure if this is an expected behavior.
Anyway posting a proposal

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task - Error is shown on blur

What is the root cause of that problem?

We validate the fields by default as you can see below

App/src/components/Form.js

Lines 301 to 304 in 4af18f6

	setTimeout(() => {
	setTouchedInput(inputID);
	onValidate(inputValues);
	}, 200);

This is the root cause

What changes do you think we should make in order to solve the problem?

I suggest to add the props called validateOnBlur to the form with default = true. If this value is set to false, we don't validate the form.

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error is shown as soon as app is put in background when creating a task.

What is the root cause of that problem?

App/src/components/Form.js

Lines 300 to 317 in 1205a74

	onBlur: (event) => {
	// We delay the validation in order to prevent Checkbox loss of focus when
	// the user are focusing a TextInput and proceeds to toggle a CheckBox in
	// web and mobile web platforms.
	setTimeout(() => {
	setTouchedInput(inputID);
	// To prevent server errors from being cleared inadvertently, we only run validation on blur if any form values have changed since the last validation/submit
	const shouldValidate = !_.isEqual(inputValues, lastValidatedValues.current);
	if (shouldValidate) {
	onValidate(inputValues);
	}
	}, 200);
	if (_.isFunction(child.props.onBlur)) {
	child.props.onBlur(event);
	}
	},

In the above code, the onBlur event is triggered when an input field loses focus. In other words, it’s executed when a user moves away from an input field.

When the app goes from the background to the foreground the onBlur event is triggered and onValidate(inputValues) function is invoked.

This is the root cause of this problem.

What changes do you think we should make in order to solve the problem?

One approach to do this is to introduce a state that tracks whether the form has been submitted or not. Validation will only run when the form has been submitted.

Here’s how we could modify the NewTaskDetailsPage.js:

function NewTaskPage(props) {
    const inputRef = useRef();
    const [taskTitle, setTaskTitle] = useState(props.task.title);
    const [taskDescription, setTaskDescription] = useState(props.task.description || '');
+   const [isSubmitted, setIsSubmitted] = useState(false); // Add this line to track form submission

    useEffect(() => {
        setTaskTitle(props.task.title);
        setTaskDescription(props.task.description || '');
    }, [props.task]);

    function validate(values) {
        const errors = {};

+       if (!values.taskTitle && isSubmitted) { // Add isSubmitted condition here
            ErrorUtils.addErrorMessage(errors, 'taskTitle', 'newTaskPage.pleaseEnterTaskName');
        }

        return errors;
    }

    function onSubmit(values) {
+       setIsSubmitted(true); // Set isSubmitted to true when form is submitted
        Task.setDetailsValue(values.taskTitle, values.taskDescription);
        Navigation.navigate(ROUTES.NEW_TASK);
    }

    // ... rest of your code
}

What alternative solutions did you explore? (Optional)

None

[NicMendonca]

@thienlnam is this expected behaviour?

[thienlnam]

Not really a big problem, but I guess worth fixing

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f687ec29289cd8a