[HOLD for c+ newdot payment][$1000] Compose box loses focus when reclicking same chat in LHN

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Notice that the composer is focused
3. Click on the same chat in LHN. Notice the composer loses focus

Expected Result:

Compose box don't lose focus when Clicking on the same chat in LHN

Actual Result:

Compose box loses focus

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test87.Composerlosefocus-1.mp4

Recording.1360.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690317170412039

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a795f9206baa2f0c
• Upwork Job ID: 1684464091337949184
• Last Price Increase: 2023-08-07
2023-07-27
• Automatic offers:
• daveSeife | Reporter | 25800239
• tienifr | Contributor | 26045509

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App loses focus from compose box on clicking same chat in LHN for the 2nd time

What is the root cause of that problem?

This issue has been fixed previously in #21552 where we prevent opening Report page when re-clicking the active report. Here we retrieved the currentReportID using withCurrentReportID HOC.

App/src/pages/home/sidebar/SidebarLinks.js

Lines 148 to 158 in 5ffd4e6

	showReportPage(option) {
	// Prevent opening Report page when clicking LHN row quickly after clicking FAB icon
	// or when clicking the active LHN row
	// or when continuously clicking different LHNs, only apply to small screen
	// since getTopmostReportId always returns on other devices
	if (this.props.isCreateMenuOpen || this.props.currentReportID === option.reportID || (this.props.isSmallScreenWidth && Navigation.getTopmostReportId())) {
	return;
	}
	Navigation.navigate(ROUTES.getReportRoute(option.reportID));
	this.props.onLinkClick();
	}

However after the major refactor in #21406, withCurrentReportID HOC was lifted up to the parent component SidebarLinksData to optimize performance. Unfortunately, the author might have forgotten about the above mentioned line where we relied on currentReportID. Thus it will always be undefined.

What changes do you think we should make in order to solve the problem?

Lift the check this.props.currentReportID === option.reportID up to SidebarLinksData as a callback:

const isActiveReport = useCallback((option) => currentReportID === option.reportID, [currentReportID]);

Declare proper prop types for SidebarLinks and pass the callback to it.

Update: For the callback, in order not to use currentReportID as a dependency of the callback, which leads to the callback re-render too often, we should save it in a ref instead and update it in a useEffect. We already have a usePrevious for that.

const prevCurrentReportID = usePrevious(currentReportID);
const isActiveReport = useCallback((option) => prevCurrentReportID === option.reportID, [prevCurrentReportID]);

[kadiealexander]

Repro:

2023-07-27_19-21-06.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a795f9206baa2f0c

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Santhosh-Sellavel]

@mountiny @hannojg @0xmiroslav Check this proposal. This is a regression from #21406, please take care.