[HOLD for payment 2023-09-06] [$1000] Android - Clicking on different option quickly opens many tabs

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click at your avatar
2. Click on different option quickly

Expected Result:

The app should opens only the first clicked option

Actual Result:

The app opens all the clicked options

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230728-231420.mp4

Screen_Recording_20230729_132217_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @muxriddinmuqimov77
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688707995939759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016e037ea65271ad6b
• Upwork Job ID: 1686148949072994304
• Last Price Increase: 2023-07-31
• Automatic offers:
• tienifr | Contributor | 26033117
• mejed-alkoutaini | Reporter | 26033119

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmdshrif]

Proposal

Please re-state the problem that we are trying to solve in this issue.

click on two options quickly in the settings, two pages open simultaneously due to multiple navigation actions being fired

What is the root cause of that problem?

two navigation actions are triggered in quick succession, and we don't have a mechanism in place to prevent multiple navigations from happening simultaneously.

What changes do you think we should make in order to solve the problem?

Instead of directly calling the navigation function as shown in the code snippet below:

App/src/pages/settings/InitialSettingsPage.js

Lines 187 to 189 in eb02006

	action: () => {
	Navigation.navigate(ROUTES.SETTINGS_SHARE_CODE);
	},

We will create a new debounced navigation function that ensures the navigation is not called multiple times within a short period. This will prevent rapid and unintended navigation.

constructor(props) {
      this.navigate = _.debounce(this.navigate.bind(this), 300);
...
}  

navigate(route) {
    Navigation.navigate(route);
}      

...
 action: () => {
    // add to all actions
    thsi.navigate(ROUTES.SETTINGS_SHARE_CODE);
}        

What alternative solutions did you explore? (Optional)

we can introduce a disableOptionForNavigation flag to prevent the navigation function from being called again while the previous navigation is still being processed. This flag should be set to true when the first navigation is triggered and reset to false when the setting focus change (if blurred mean navigation is complete )

componentDidUpdate(prevProps) {
// if focus change we need to reset flage
    if (this.props.isFocused !== prevProps.isFocused && this.disableOptionForNavigation ) {
        this.disableOptionForNavigation = false;
    }
}

const NavigateWithDisable  (route ) {
  if (this.disableOptionForNavigation){
      return;
  }
  Navigation.navigate(route);
  this.this.disableOptionForNavigation = true;
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016e037ea65271ad6b

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mallenexpensify]

Was able to repro on Daniel Silva's phone, I wasn't able to via BrowserStack. Seems like an External issue...