[HOLD for payment 2023-11-21] [$1000] Not Allowed sign is not shown when dragging attachments on Archived rooms

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any Archived Room
2. Drag the attachment on The Archived Room

Expected Result:

The not Allowed sign is shown when dragging attachments on Archived rooms

Actual Result:

Copy sign is shown when dragging attachments on Archived rooms

Workaround:

unknown
\

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.1108.mp4

Test96.Archiveddrop-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690837081412469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01340b7f14e5ffd467
• Upwork Job ID: 1689576290227458048
• Last Price Increase: 2023-08-17
• Automatic offers:
• hungvu193 | Contributor | 27333272
• daveSeife | Reporter | 27333275

Issue Owner

Current Issue Owner: @Santhosh-Sellavel

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not Allowed sign is not shown when dragging attachments on Archived rooms

What is the root cause of that problem?

We only disabled the DragView when isReportReadyForDisplay is false but that's not the case for this issue:

App/src/pages/home/ReportScreen.js

Line 351 in e555022

<DragAndDropProvider isDisabled={!this.isReportReadyForDisplay()}>

What changes do you think we should make in order to solve the problem?

We should also disable the DragAndDropProvider when we the the composer is hidden (archived room, not allowed to comment, report has errors).
We should change the condition here to:

<DragAndDropProvider isDisabled={!this.isReportReadyForDisplay() || ReportUtils.shouldHideComposer(this.props.report, this.props.errors)}>

Update: shouldHideComposer is now renamed to shouldDisableWriteActions, so we should replace shouldHideComposer with shouldDisableWriteActions.

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

@hungvu193 Your proposal not work for me. Could you share a result video?

[ginsuma]

I think @hungvu193's proposal will work when we disable drag and drops event everywhere (document level) except in some areas.
We have a GH for it here #22218.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01340b7f14e5ffd467

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[flaviadefaria]

Added the external label.