[HOLD for payment 2023-11-06] [$1000] IOU - All IOUs created in offline mode disappear when the second IOU is deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with Gmail account
3. Go offline
4. Create two IOUs with a user with no conversation history
5. Click on the IOU preview
6. Delete the second (latest) IOU

Expected Result:

The deleted request has strikethrough over it

Actual Result:

Both IOU requests disappear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159790_bandicam_2023-08-10_15-01-55-211.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018373aabb06ce3dc5
• Upwork Job ID: 1696471985283166208
• Last Price Increase: 2023-09-12
• Automatic offers:
• bernhardoj | Contributor | 26638438

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If we delete one transaction in an IOU report that is optimistically created while offline, the whole IOU report is deleted even though we still have other transactions.

What is the root cause of that problem?

When we delete a transaction from the IOU report, we have a condition to decide whether we want to delete the IOU report or not.

App/src/libs/actions/IOU.js

Lines 838 to 839 in 7d59bbb

	const shouldDeleteIOUReport =
	iouReportLastMessageText.length === 0 && !ReportActionsUtils.isDeletedParentAction(lastVisibleAction) && (!transactionThreadID || shouldDeleteTransactionThread);

In our case, the condition that makes shouldDeleteIOUReport becomes true is the last message of the IOU report is empty (doesn't include CREATED action). This shouldn't happen because we have other transactions in the IOU report, but still, we get an empty last message.

To understand why, we should look at how the last message/action is retrieved.

App/src/libs/ReportActionsUtils.js

Lines 379 to 388 in 7d59bbb

	function getLastVisibleAction(reportID, actionsToMerge = {}) {
	const actions = _.toArray(lodashMerge({}, allReportActions[reportID], actionsToMerge));
	const visibleActions = _.filter(actions, (action) => shouldReportActionBeVisibleAsLastAction(action));
	if (_.isEmpty(visibleActions)) {
	return {};
	}
	return _.max(visibleActions, (action) => moment.utc(action.created).valueOf());
	}

Let's say we have 2 optimistic transactions/requests and we delete the 2nd one. First, we merge the IOU report actions with actionsToMerge. actionsToMerge is the action/transaction/request that we delete. In this case, we have 2 actions left, that is the CREATED action and the first transaction.

Next, we are filtering out any action that shouldn't be visible, nothing changes here. Last, we iterate over the actions and take the one that has the biggest created value. This is where the problem lies.

Both CREATED and the first transaction action has the same created value.

Thus, the CREATED action is returned as the last message.

If it's a CREATED action, we return an empty string.

App/src/libs/ReportActionsUtils.js

Lines 405 to 409 in 7d59bbb

	if (isCreatedAction(lastVisibleAction)) {
	return {
	lastMessageText: '',
	};
	}

In the online case, the server returned a bigger created value for the transaction action.

What changes do you think we should make in order to solve the problem?

We actually have a comment saying that we should create the CREATED action first.

App/src/libs/actions/IOU.js

Lines 374 to 377 in 7d59bbb

	// Note: The CREATED action for the IOU report must be optimistically generated before the IOU action so there's no chance that it appears after the IOU action in the chat
	const optimisticCreatedActionForChat = ReportUtils.buildOptimisticCreatedReportAction(payeeEmail);
	const optimisticCreatedActionForIOU = ReportUtils.buildOptimisticCreatedReportAction(payeeEmail);
	const optimisticIOUAction = ReportUtils.buildOptimisticIOUReportAction(

But looks like that doesn't enough because the date returned for both actions is the same. The solution is to add at least 1 ms to the transaction/request action.

App/src/libs/ReportUtils.js

Line 1844 in 7d59bbb

created: DateUtils.getDBTime(),

We can create a new util function called addMillisecondsToDateTime that will work similarly to subtractMillisecondsFromDateTime

created: DateUtils.addMillisecondsToDateTime(DateUtils.getDBTime(), 1),

[muttmuure]

Will get to this after higher priority issues

[melvin-bot]

@muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[muttmuure]

Picking this up this week

[melvin-bot]

@muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!