After sending a message in offline mode and going back to online, messages are repeated when refreshing the page

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

Only 1 message should be displayed.

Actual Result:

Message is sent twice when refreshing the page after coming back online.

Action Performed:

1. Log in to staging.expensify.cash
2. Navigate to a conversation
3. Disable the internet connection
4. Send a message while offline
5. Enable the internet connection and immediately refresh the page

Workaround:

If the user does not refresh the page only 1 message is displayed.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.24-1

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

OFFLINE.mp4

Expensify/Expensify Issue URL:

---

From @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p1618602399353800

ISSUE: After sending a message in offline mode and going back to online, messages is repeated(sent twice).

Upwork job: https://www.upwork.com/jobs/~0151bfc06bb91fc01c

[MelvinBot]

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

@isagoico I think this video is not working. It would be better to just attach the video link. Converting Webm to mp4 has some issues.

[parasharrajat]

@isagoico Working video

video.mp4

[marcaaron]

Nice catch @parasharrajat. Guessing we are just not clearing the queue out once the queue is allowed to run here?

I think we were mainly focused on the case of:

1. Go offline
2. Leave a comment
3. Refresh page
4. Go online
5. Comment is sent

[parasharrajat]

@marcaaron Yes. message queue should be cleared when the queued messages are processed after user comes back online.

But one important point to take is that we should only process the queue when the client is leader.

I have tested it. Proposal is ready.

Even queue processing should be done by leader as we share the localhost across tabs

[marcaaron]

Ok, I think we can skip most of triage then and get this fast tracked.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Are we ready to move on this one? I am willing to fix this.

[puneetlath]

Sorry for the delay Rajat. Here's the job: https://www.upwork.com/jobs/~0151bfc06bb91fc01c